From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93DE94A33 for ; Mon, 20 May 2024 01:40:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716169239; cv=none; b=tZcAJlBjzEpEtHnBdhMoht+q7TMQj1mrgK8oKah4jdIdqptJyPm/SUYEv4ssgMZ14mapTQpHWfhPeMiVlWpzkk52fWj6L2LsR3NaFbm8q1SanOD0e+5/cy57at6VqKQ9t/zZjHQt5nQV6yUeDs+F5khnfZzCxegxukM6PyLU5Rk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716169239; c=relaxed/simple; bh=v7BNjDNjna79xAB70CuhL0W6lWarPN4nUAKjM5i0OJM=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=hGW1WLis1VeSVcqucfCDVi64zh2jy04LZPxrKuwCWGm74xG5ZUBfT0Cxopa4P4FGc4hpFvsfOa7tvxDgitJQUaIkNoCf69ccT+Ld9av3uHLqWNq6a32FPueLXjM6sszB0rGQmZpoTHgK3MoacMzhARJOWQxzdZeuAgHyL5drYDs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=EBbgjuZB; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="EBbgjuZB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716169239; x=1747705239; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=v7BNjDNjna79xAB70CuhL0W6lWarPN4nUAKjM5i0OJM=; b=EBbgjuZBX0Q5VnQOlY1jf2AWghvxwHt2906ImyevhH9yIbzom+A+WZNP eXWAcxuddsDgA7rY/gJRnxWQh3JZlnDVsx7upuUx4PNRoeKW0bxcTs1/B DVuUw3oub8TenARS2qywaBg9Uq+/7gO65E4b7Xal4xcRt8DD9e9PgyAOd uNP06lydsaWsgqLmv+lLsEsswJNaPCda7Y1KHklZizf4BY7qBqG7RMcK1 7veazvOIzjefQKJtRa24OvzuNMrH+NvXXmYtpKfWjJz4e2h4v1RPEuTDK 3IpU3X9lYkn9d8HSZtDcg/ZMhtseJ5Qi3xNW/8xR32ABZxTm78+2c9oot g==; X-CSE-ConnectionGUID: biKJKn1UTZanB7Zim9I+lA== X-CSE-MsgGUID: 34k1kRahRLW9c9MhrQH9zA== X-IronPort-AV: E=McAfee;i="6600,9927,11077"; a="15222442" X-IronPort-AV: E=Sophos;i="6.08,174,1712646000"; d="scan'208";a="15222442" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2024 18:40:37 -0700 X-CSE-ConnectionGUID: FFh+bDzaR+iXthcEUOL9DQ== X-CSE-MsgGUID: qneolWTNTlKzAfNseBaoiw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,174,1712646000"; d="scan'208";a="32278942" Received: from unknown (HELO [10.239.159.127]) ([10.239.159.127]) by fmviesa007.fm.intel.com with ESMTP; 19 May 2024 18:40:33 -0700 Message-ID: <10df7c77-4848-42d2-ad00-70badc7a9ae8@linux.intel.com> Date: Mon, 20 May 2024 09:38:42 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: baolu.lu@linux.intel.com, "iommu@lists.linux.dev" , "virtualization@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v5 5/9] iommufd: Add iommufd fault object To: "Tian, Kevin" , Jason Gunthorpe , Joerg Roedel , Will Deacon , Robin Murphy , Jean-Philippe Brucker , Nicolin Chen , "Liu, Yi L" , Jacob Pan , Joel Granados References: <20240430145710.68112-1-baolu.lu@linux.intel.com> <20240430145710.68112-6-baolu.lu@linux.intel.com> Content-Language: en-US From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/15/24 4:37 PM, Tian, Kevin wrote: >> + iopf_free_group(group); >> + done += response_size; >> + >> + iommufd_put_object(fault->ictx, &idev->obj); > get/put is unpaired: > > if (!idev || idev->obj.id != response.dev_id) > idev = iommufd_get_object(); > > ... > > iommufd_put_object(idev); > > The intention might be reusing idev if multiple fault responses are > for a same idev. But idev is always put in each iteration then following > messages will access the idev w/o holding the reference. Good catch. Let me fix it by putting the response queue in the fault object. Best regards, baolu