From: Joe Perches <joe@perches.com>
To: Sui Chen <suichen@google.com>, linux-kernel@vger.kernel.org
Cc: openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org,
joel@jms.id.au, andrew@aj.id.au, tali.perry1@gmail.com,
benjaminfair@google.com, krellan@google.com
Subject: Re: [RFC Patch v2 1/3] i2c debug counters as sysfs attributes
Date: Thu, 02 Dec 2021 18:50:27 -0800 [thread overview]
Message-ID: <10e59e850894524d34cc7d89c126ab9133e6a1a7.camel@perches.com> (raw)
In-Reply-To: <20211203023728.3699610-2-suichen@google.com>
On Thu, 2021-12-02 at 18:37 -0800, Sui Chen wrote:
> This change adds a few example I2C debug counters as sysfs attributes:
> - ber_cnt (bus error count)
> - nack_cnt (NACK count)
> - rec_fail_cnt, rec_succ_cnt (recovery failure/success count)
> - timeout_cnt (timeout count)
> - i2c_speed (bus frequency)
> - tx_complete_cnt (transaction completed, including both as an initiator
> and as a target)
>
> The function i2c_adapter_create_stats_folder creates a stats directory
> in the device's sysfs directory to hold the debug counters. The platform
> drivers are responsible for instantiating the counters in the stats
> directory if applicable.
Please try to use scripts/checkpatch.pl on your patches and see if
you should be more 'typical kernel style' compliant.
Ideally, use the --strict option too.
next prev parent reply other threads:[~2021-12-03 2:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 2:37 [RFC Patch v2 0/3] I2C statistics " Sui Chen
2021-12-03 2:37 ` [RFC Patch v2 1/3] i2c debug counters " Sui Chen
2021-12-03 2:50 ` Joe Perches [this message]
2021-12-03 5:35 ` Sui Chen
2021-12-03 5:54 ` Joe Perches
2021-12-03 2:37 ` [RFC Patch v2 2/3] i2c: npcm7xx: add tx_complete counter Sui Chen
2021-12-03 2:37 ` [RFC Patch v2 3/3] add npcm7xx debug counters as sysfs attributes Sui Chen
2021-12-03 16:37 ` [RFC Patch v2 0/3] I2C statistics " Wolfram Sang
2021-12-07 16:00 ` Sui Chen
2022-01-03 9:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10e59e850894524d34cc7d89c126ab9133e6a1a7.camel@perches.com \
--to=joe@perches.com \
--cc=andrew@aj.id.au \
--cc=benjaminfair@google.com \
--cc=joel@jms.id.au \
--cc=krellan@google.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=suichen@google.com \
--cc=tali.perry1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®