From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751125AbeAVLNL (ORCPT ); Mon, 22 Jan 2018 06:13:11 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:57240 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbeAVLNK (ORCPT ); Mon, 22 Jan 2018 06:13:10 -0500 Cc: Sudeep Holla , devicetree , Linux Kernel list , Loys Ollivier , Bjorn Andersson , Rob Herring , Frank Rowand Subject: Re: [PATCH -next] of: platform: fix OF node refcount leak To: Andy Gross References: <1516272219-25359-1-git-send-email-sudeep.holla@arm.com> From: Sudeep Holla Organization: ARM Message-ID: <10e5ef22-37e5-986f-eda0-446214c5626b@arm.com> Date: Mon, 22 Jan 2018 11:13:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/01/18 23:34, Andy Gross wrote: > On 19 January 2018 at 09:37, Sudeep Holla wrote: >> Hi Andy, >> >> On 18/01/18 10:43, Sudeep Holla wrote: >>> We need to call of_node_put() for device nodes obtained with >>> of_find_node_by_path(). >>> >>> Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()") >>> Reported-by: Loys Ollivier >>> Cc: Rob Herring >>> Cc: Frank Rowand >>> Signed-off-by: Sudeep Holla >>> --- >>> drivers/of/platform.c | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >> >> Can you pick up this with other fixes you would send after v4.16-rc1 or >> do you prefer me to route through ARM-SoC directly ? Let me know. > > I can pick this up for fixes, no problem. I can send it along right > now if you like. This is a pretty low risk patch. > Thanks Andy. -- Regards, Sudeep