From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9A1DC32ED21 for ; Wed, 14 Jan 2026 05:20:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768368041; cv=none; b=apy1PHjrFsaFspykrxQxNlPQBC8Ajkk6dpH/Z8M7UAmTAns591er40nSDzN/6xR7eCBvYr6AWpHwnqsfoebhWOcaxm4fGQthLt9oU0EIrvv9RpW55GmsHrcnEBQx84o0LjxrB3+WJ2Hq1+9D41HuLQTUE1xAGoD40Gk4XpSaiYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768368041; c=relaxed/simple; bh=Rkrt/GuRY7RYAV8iblaglDLmiOzQpa+hm0N/StkHRKY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZsqBZ+XOEYynJba2sI0L1CqJTtBApwe5r0JSZsofDGIRTmt8gqVfM+2agh20hwO3/1yd3Y/wpfw4FRZ5QkSOzIQyWgHKgA03IFmglrwny9kcWQh1GvmSMvqUu5v5pybYQikPQaotspTOvWKwOTrvg+2jNUyGTLoU4C2ZdkCh1K0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BEB4C497; Tue, 13 Jan 2026 21:20:18 -0800 (PST) Received: from [10.163.161.65] (unknown [10.163.161.65]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8EEF03F694; Tue, 13 Jan 2026 21:20:23 -0800 (PST) Message-ID: <10ebbce4-1b83-4eb2-99f3-738a0e613958@arm.com> Date: Wed, 14 Jan 2026 10:50:19 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/khugepaged: make khugepaged_collapse_control static To: Ben Dooks , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, david@kernel.org, lorenzo.stoakes@oracle.com References: <20260112161818.604651-1-ben.dooks@codethink.co.uk> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20260112161818.604651-1-ben.dooks@codethink.co.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/01/26 9:48 PM, Ben Dooks wrote: > Make khugepaged_collapse_control as it is not exported. > Fixes the following sparse warning: > > mm/khugepaged.c:829:25: warning: symbol 'khugepaged_collapse_control' was not declared. Should it be static? > > Fixes: 34d6b470ab9cf ("mm/khugepaged: add struct collapse_control") > Signed-off-by: Ben Dooks > --- > mm/khugepaged.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 97d1b2824386..c9bd0df632bd 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -826,7 +826,7 @@ static void khugepaged_alloc_sleep(void) > remove_wait_queue(&khugepaged_wait, &wait); > } > > -struct collapse_control khugepaged_collapse_control = { > +static struct collapse_control khugepaged_collapse_control = { > .is_khugepaged = true, > }; > Reviewed-by: Anshuman Khandual