mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Enver Ikromov <owner@ph4ntom-rev.uz>
Cc: Zong-Zhe Yang <kevin_yang@realtek.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH rtw-next v7 5/5] wifi: rtw89: honor ASSIGN_SEQ, retries, and NO_ACK for injected frames
Date: Thu, 19 Nov 2026 07:27:53 +0000	[thread overview]
Message-ID: <10ecdda16085441c9eb930bc88c79c6b@realtek.com> (raw)
In-Reply-To: <20261118180435.904-6-owner@ph4ntom-rev.uz>

Enver Ikromov <owner@ph4ntom-rev.uz> wrote:
> Injected management frames currently overwrite caller-supplied sequence
> numbers because hardware sequence numbering remains enabled when
> IEEE80211_TX_CTL_ASSIGN_SEQ is unset, and injected frames ignore NO_ACK
> and explicit radiotap retry limits.
> 
> Preserve the caller's sequence number when IEEE80211_TX_CTL_ASSIGN_SEQ
> is not set, apply NO_ACK in TX descriptors and completion status, and
> honor radiotap retry counts up to RTW89_TX_DATA_CNT_LMT_MAX (63).

Since RTL8852AE doesn't have NO_ACK in TX descriptor, so please note this
in commit message. 

> @@ -1800,7 +1814,9 @@ static __le32 rtw89_build_txwd_body5_v2(struct rtw89_tx_desc_info *desc_info)
> 
>  static __le32 rtw89_build_txwd_body6_v2(struct rtw89_tx_desc_info *desc_info)
>  {
> -       u32 dword = FIELD_PREP(BE_TXD_BODY6_UPD_WLAN_HDR, desc_info->upd_wlan_hdr);
> +       u32 dword = FIELD_PREP(BE_TXD_BODY6_NO_ACK, desc_info->no_ack) |
> +                   FIELD_PREP(BE_TXD_BODY6_UPD_WLAN_HDR,
> +                              desc_info->upd_wlan_hdr);

Just straighten as original (a little over 80 characters). 




  reply	other threads:[~2026-11-19  7:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 18:04 [PATCH rtw-next v7 0/5] wifi: rtw89: monitor mode and raw frame injection fixes Enver Ikromov
2026-11-18 18:04 ` [PATCH rtw-next v7 1/5] wifi: rtw89: avoid NULL vif dereference in rtw89_ops_tx() Enver Ikromov
2026-11-19  7:08   ` Ping-Ke Shih
2026-11-18 18:04 ` [PATCH rtw-next v7 2/5] wifi: rtw89: handle negative rate index for injected frames Enver Ikromov
2026-11-19  7:11   ` Ping-Ke Shih
2026-11-18 18:04 ` [PATCH rtw-next v7 3/5] wifi: rtw89: restore channel when leaving idle on non-chanctx devices Enver Ikromov
2026-11-19  5:13   ` Zong-Zhe Yang
2026-11-19  7:14     ` Ping-Ke Shih
2026-11-18 18:04 ` [PATCH rtw-next v7 4/5] wifi: rtw89: avoid reading seq_ctrl on control frames Enver Ikromov
2026-11-19  7:17   ` Ping-Ke Shih
2026-11-19  7:35   ` Ping-Ke Shih
2026-11-18 18:04 ` [PATCH rtw-next v7 5/5] wifi: rtw89: honor ASSIGN_SEQ, retries, and NO_ACK for injected frames Enver Ikromov
2026-11-19  7:27   ` Ping-Ke Shih [this message]
2026-11-19  8:02     ` Enver Ikromov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10ecdda16085441c9eb930bc88c79c6b@realtek.com \
    --to=pkshih@realtek.com \
    --cc=kevin_yang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=owner@ph4ntom-rev.uz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®