mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Davis <afd@ti.com>
To: Jayesh Choudhary <j-choudhary@ti.com>, <devicetree@vger.kernel.org>
Cc: <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am62-main: Enable crypto accelerator
Date: Thu, 23 Jun 2022 13:21:28 -0500	[thread overview]
Message-ID: <10ee5d87-47bd-d423-75a5-611fefe7a656@ti.com> (raw)
In-Reply-To: <20220623095955.161307-1-j-choudhary@ti.com>

On 6/23/22 4:59 AM, Jayesh Choudhary wrote:
> Add the node for sa3ul crypto accelerator.
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> ---
> On local testing, crypto self-tests and tcrypt tests were passing
> for SHA256, SHA512, ECB-AES and CBC-AES algorithms.
> RNG node has not been added due to the indirect access of the
> hardware random number generator from OP-TEE.
> 
>   arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index df3b9883e887..30bd22ff2fc9 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -165,6 +165,19 @@
>   		};
>   	};
>   
> +	crypto: crypto@40900000 {
> +		compatible = "ti,am62-sa3ul";
> +		reg = <0x00 0x40900000 0x00 0x1200>;
> +		power-domains = <&k3_pds 70 TI_SCI_PD_EXCLUSIVE>;


Change to TI_SCI_PD_SHARED as OP-TEE uses this too, otherwise looks good,

Acked-by: Andrew Davis <afd@ti.com>


> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
> +
> +		dmas = <&main_pktdma 0xf501 0>, <&main_pktdma 0x7506 0>,
> +				<&main_pktdma 0x7507 0>;
> +		dma-names = "tx", "rx1", "rx2";
> +	};
> +
>   	main_pmx0: pinctrl@f4000 {
>   		compatible = "pinctrl-single";
>   		reg = <0x00 0xf4000 0x00 0x2ac>;

      reply	other threads:[~2022-06-23 19:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-23  9:59 Jayesh Choudhary
2022-06-23 18:21 ` Andrew Davis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10ee5d87-47bd-d423-75a5-611fefe7a656@ti.com \
    --to=afd@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-choudhary@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®