From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dzmitry Sankouski <dsankouski@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>, Lee Jones <lee@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Hans de Goede <hdegoede@redhat.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>,
Purism Kernel Team <kernel@puri.sm>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v15 6/7] input: max77693: add max77705 haptic support
Date: Fri, 17 Jan 2025 09:02:35 +0100 [thread overview]
Message-ID: <10f0fdac-65fb-4232-9d39-d6ecb2560b45@kernel.org> (raw)
In-Reply-To: <20250117-chubby-convivial-axolotl-29e2df@krzk-bin>
On 17/01/2025 09:01, Krzysztof Kozlowski wrote:
>
>> case TYPE_MAX77843:
>> haptic->regmap_haptic = max77693->regmap;
>> break;
>> @@ -407,6 +418,7 @@ static DEFINE_SIMPLE_DEV_PM_OPS(max77693_haptic_pm_ops,
>>
>> static const struct platform_device_id max77693_haptic_id[] = {
>> { "max77693-haptic", },
>> + { "max77705-haptic", },
>> { "max77843-haptic", },
... and also drop this change, since compatible is going away and we
expect matching by OF.
>> {},
>> };
>> @@ -414,6 +426,7 @@ MODULE_DEVICE_TABLE(platform, max77693_haptic_id);
>>
>> static const struct of_device_id of_max77693_haptic_dt_match[] = {
>> { .compatible = "maxim,max77693-haptic", },
>> + { .compatible = "maxim,max77705-haptic", },
>
> So the device looks fully compatible with max77693. Drop this change and
> express compatibility with fallback.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-17 8:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 16:26 [PATCH v15 0/7] Add support for Maxim Integrated MAX77705 PMIC Dzmitry Sankouski
2025-01-16 16:26 ` [PATCH v15 1/7] dt-bindings: power: supply: add maxim,max77705 charger Dzmitry Sankouski
2025-01-16 16:26 ` [PATCH v15 2/7] dt-bindings: mfd: add maxim,max77705 Dzmitry Sankouski
2025-01-16 16:26 ` [PATCH v15 3/7] power: supply: max77705: Add charger driver for Maxim 77705 Dzmitry Sankouski
2025-01-16 16:26 ` [PATCH v15 4/7] mfd: simple-mfd-i2c: Add MAX77705 support Dzmitry Sankouski
2025-01-16 16:26 ` [PATCH v15 5/7] mfd: Add new driver for MAX77705 PMIC Dzmitry Sankouski
2025-01-17 7:55 ` Krzysztof Kozlowski
2025-01-17 11:53 ` Dzmitry Sankouski
2025-01-16 16:26 ` [PATCH v15 6/7] input: max77693: add max77705 haptic support Dzmitry Sankouski
2025-01-17 8:01 ` Krzysztof Kozlowski
2025-01-17 8:02 ` Krzysztof Kozlowski [this message]
2025-01-17 12:40 ` Dzmitry Sankouski
2025-01-17 12:32 ` Dzmitry Sankouski
2025-01-16 16:26 ` [PATCH v15 7/7] leds: max77705: Add LEDs support Dzmitry Sankouski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10f0fdac-65fb-4232-9d39-d6ecb2560b45@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dsankouski@gmail.com \
--cc=hdegoede@redhat.com \
--cc=kernel@puri.sm \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=sebastian.krzyszkowiak@puri.sm \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®