From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Paulo Pavacic <pavacic.p@gmail.com>
Cc: neil.armstrong@linaro.org, sam@ravnborg.org, airlied@gmail.com,
daniel@ffwll.ch, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/3] drm/panel-fannal-c3003: Add fannal c3004 DSI panel
Date: Tue, 6 Jun 2023 16:52:55 +0200 [thread overview]
Message-ID: <10fa8759-a1c5-6592-e0be-98574fb635c3@linaro.org> (raw)
In-Reply-To: <CAO9szn05edU_HZHVnREMZcwm6TbBa4psABoqSqLWghFc=KbV7w@mail.gmail.com>
On 06/06/2023 09:36, Paulo Pavacic wrote:
>>> +
>>> + if (IS_ERR(panel_data->reset)) {
>>> + ret = PTR_ERR(panel_data->reset);
>>> + dev_err(dev,
>>> + "error: probe: get reset GPIO: (%d) Check the fdt\n",
>>> + ret);
>>
>> return dev_err_probe
>>
>>> + return ret;
>>> + }
>>> +
>>> + mipi_dsi_set_drvdata(dsi, panel_data);
>>> +
>>> + dsi->format = MIPI_DSI_FMT_RGB888;
>>> + dsi->mode_flags = MIPI_DSI_CLOCK_NON_CONTINUOUS |
>>> + MIPI_DSI_MODE_VSYNC_FLUSH | MIPI_DSI_MODE_VIDEO_HSE |
>>> + MIPI_DSI_MODE_NO_EOT_PACKET |
>>> + MIPI_DSI_MODE_VIDEO_SYNC_PULSE | MIPI_DSI_MODE_VIDEO;
>>> + dsi->lanes = 2;
>>> +
>>> + gpiod_set_value_cansleep(panel_data->reset, 1);
>>
>> So you leave the panel in reset state?
> yes
Then why do you initialize GPIO to bring it out of reset and them
immediately put into reset back? Just keep it in reset.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-06-06 14:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 15:35 [PATCH v2 0/3] drm/panel: add fannal c3004 panel Paulo Pavacic
2023-06-05 15:35 ` [PATCH v2 1/3] dt-bindings: add fannal vendor prefix Paulo Pavacic
2023-06-06 7:07 ` Krzysztof Kozlowski
2023-06-05 15:35 ` [PATCH v2 2/3] dt-bindings: display: panel: add fannal,c3004 Paulo Pavacic
2023-06-06 7:10 ` Krzysztof Kozlowski
2023-06-06 9:53 ` Paulo Pavacic
2023-06-06 14:51 ` Krzysztof Kozlowski
2023-06-05 15:35 ` [PATCH v2 3/3] drm/panel-fannal-c3003: Add fannal c3004 DSI panel Paulo Pavacic
2023-06-06 7:14 ` Krzysztof Kozlowski
2023-06-06 7:36 ` Paulo Pavacic
2023-06-06 14:52 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10fa8759-a1c5-6592-e0be-98574fb635c3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=pavacic.p@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®