From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D71D1339B3B for ; Tue, 17 Feb 2026 12:29:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771331349; cv=none; b=sV1Mh2RoQYDlFmF1kRULkjSPYOma3EzEfGWWmLYcQYQcfFEvjsnczS6Of9Ly9WyzI4pkvFReXW+Mj5HfJt4XjQRm1UuhYOr8Fr51vp8wgFMt6roouJSjx5rniGTeHWYJX+DOueDQmyWK+OY+5ZfLLEeXOgW3n91kxBta/mn36TY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771331349; c=relaxed/simple; bh=VRN60Fr3kj7zvwSlwYxaIWmnxVA6ckGzGv9Tvn2DwJs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hUpIyfgZK/29nLU3teFThGnuFnriCAMq3P9A/3crH6WonRWdO5rOeUDFGksyt398iDDi4mROK8ePe0RI1KBZFyGBdZpV0I5Ktof8O2gGUsH71Wdz2ksIJryWf0K3JiwuYmNQlnBEt6jaTZZGekFBZVBFfCxQB6dtx4YpuX8pbRw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZNNLACd6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=U8zBlmcC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZNNLACd6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="U8zBlmcC" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61H8vAFE287925 for ; Tue, 17 Feb 2026 12:29:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lfN+j7iPplW7HNJqPxQ5mLmsOyD6t4QrPPRMvKjKBi4=; b=ZNNLACd6DqncwSV+ Ri+bSrpWj/CDBCMOF2OBihNF6XcChI25PN+EIHitEB2UEFqQ0DDvMSGhV9UroXqt 5OVmPFSt8w7xyIUeM0/2cTdKtwIoytqFgmTPhdvEu3PuUaH6LjRStLuc0j6IHOhn RHAxLuca+7Vredw93rR1MUuNs/V9RJ9sXIBIA7usd1JXHYd7O5+b7/bdgYe7uqPD Gb/qZ0WODeChXHG3X9DODHLAe84rBgNzmmQa/tH7/20k2ojStjMdZw+G2f9XlAOQ 4YS4g4ZcpSyHn/6ZtkRYoOKxQBHxb5ibwbp6nozT9wWj9gzmWui50MsjhiZrlAZp q/qolQ== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cc6nrt9ms-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Feb 2026 12:29:06 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-89547ddf32bso31379916d6.2 for ; Tue, 17 Feb 2026 04:29:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771331346; x=1771936146; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lfN+j7iPplW7HNJqPxQ5mLmsOyD6t4QrPPRMvKjKBi4=; b=U8zBlmcC5XtobSpTJRpW0A7MR2q69nzf56p4SqUxMolRo7EqzKHbG5LThCJMXVzmR3 gtjOdDxwndJdQZiUhPj7aH4JTRZ+YbxZTeqYAoMTFswZhpRYQRwKBTODhUbZjjXbxr9h T+1lx5DyAZ4MT8qaeIc1WKESy9UKUgdC3FVgAU78oRTBs6gpaux0zZmHXsKo7WevqC0c 7vsY/7XSrpMVqxooRoK01+3lEu4TkiqYXi6kS03qaIA1y5JAHc+tclMsMXliVkLjABo2 mWGpD1m1y1tKc5j0AuzRJczRTJN2aOPLSezfwHkuAh3WIM9cricRRQhn7BVXWLUv18P7 QbnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771331346; x=1771936146; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lfN+j7iPplW7HNJqPxQ5mLmsOyD6t4QrPPRMvKjKBi4=; b=cyQQLd+PfMm77pEW5aDqe6A3A6zlQ+tFRs9V1omijsY6IpbcMmW6artZh/8aZGspg7 mclRu0vbZ0o+FcJfyJm9UKkJ1PQT3FidHJBNeelqjzxfiVRfboU2YT4LnKRjKsBOW2XI EOANmsRgowLpbp5IpCPPH0gL1GOw6P7QoJbaiOvcxTJVFSdC4VAZTeQVS8OFNSeLudi6 O0oEbOIENTA6dCtYk1qtWHnKJ+126k/GKb6+5fW8USXKpkM+SM1NMPyDpmGObF6ZlNUB ZWgN+zq0Za6sq0KBqPdhgQpYH3jEMRGVNMtAsxtSGuSGIoVWlblGbeFmNEftHsgUAnWj Azbw== X-Forwarded-Encrypted: i=1; AJvYcCWM8eJXzu9vraTBwR3fVjTUawpehIJmm58ykHtndVCfR/sf/S7UMsIbpByw6Y8Frt1Rbjwpjk25jUfYjMY=@vger.kernel.org X-Gm-Message-State: AOJu0YwoItpAxwnhsFQQmgMRPEdGR2qSxro0A2zZOXKDRmP4yGiD4pSs KhQ1FjHRfkzSfLwoicHJdXty++k//rAhNzcHlayg7G3p4GRld3mUfpIc6RfvUyH2alJe0dq0Tcc 5UXCEtW4epcoLm2uuRbaPkEg4qU8PDFX4jK1n1dOJ26valBVvHY3abf1odDPWHOFQLjs= X-Gm-Gg: AZuq6aIFUgnSPWYWnA6AUVDNXAoqJVqyp1HYC0bzpeIw/EciRTDduA0wyIfhesIyOwX 59VMs5MIfECCRSyDs7yCGLQYDFgr1ZB92SlOoUVz+XXoRAB8oXil6Iss+xn9Yb13+TxXn9Yalw5 p5E45fdc71UJ0uvl1A2x2YYnsB4RK1O4xX/pgE3b2Ox4m1muqBkjRm5pYjlpgqhxV4QlfqbofM4 ZxNAOP9DeWPiwLzPBdG7WeD/cROf9rzE488djE79ClwGHcCKOBD5WYa6krTgTFh31ZxpUIPpJPU 4OazG31qd6SMDB9bZVMGuqtlGVfb4553GTaVKIsIzvLYeoCwMdYoBHdRMyqci60k2vrC10GJHWb tOa+x1u8t1jDC7mLzOfwSLl9VKjk0V17OkexgVY3ex0C5Nl3BfL1T2OQtzPjNW521XPzl/k/nPY wD2Hc= X-Received: by 2002:a05:6214:5e05:b0:897:1e9:578c with SMTP id 6a1803df08f44-897347b028cmr142895156d6.4.1771331346246; Tue, 17 Feb 2026 04:29:06 -0800 (PST) X-Received: by 2002:a05:6214:5e05:b0:897:1e9:578c with SMTP id 6a1803df08f44-897347b028cmr142894726d6.4.1771331345677; Tue, 17 Feb 2026 04:29:05 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc7691c48sm348833366b.59.2026.02.17.04.29.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Feb 2026 04:29:05 -0800 (PST) Message-ID: <10fad67e-52d7-46b4-b785-d6c3f556ff20@oss.qualcomm.com> Date: Tue, 17 Feb 2026 13:29:02 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU To: Rakesh Kota , Krzysztof Kozlowski Cc: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Dmitry Torokhov , Courtney Cavin , Bjorn Andersson , Konrad Dybcio , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-input@vger.kernel.org References: <20260209-add_pwrkey_and_resin-v2-0-f944d87b9a93@oss.qualcomm.com> <20260209-add_pwrkey_and_resin-v2-1-f944d87b9a93@oss.qualcomm.com> <20260210082612.3xakor2yo4h3dbra@hu-kotarake-hyd.qualcomm.com> <20260211104153.r6xz7ya5emxa36cp@hu-kotarake-hyd.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260211104153.r6xz7ya5emxa36cp@hu-kotarake-hyd.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=XKo9iAhE c=1 sm=1 tr=0 ts=69945f12 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=9iDGNwz4qdmNxc66HVYA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE3MDEwMyBTYWx0ZWRfX0l0tJJGRXAsI um2VE2TBrnSW1piFA/UWbDUKOWwyGlr1zVa/n18tdDmVr6KaeP4NiYkjsMfDMJss4qkcKcke8/Y hN9GgOStilvldrlm1JyCAXQb5YSIoHblYjkJ9KimwVRx+9uuSOfKn6hA80g4TCOd0H301GRsH6q T6u8KT4SBN5dwMQJlx1gvt//SWyXJqoJpERK9l6UQfL1IBVdA73yY/F2etUdhyaijGPREH60ot1 CFbmzOy1Lui8iqcWrCMeaG9TTJl069CAM+x3JuTmhbwn1tBUvd8r6pefml1yqWMkcsZNWLoO3JL j8OvPlA5tcAeeh6cDaZ1p3eEaNbTYHq/LeWo3tLSxal+WGfoht4nAe4/N6vhKbRMA5FyfYyQvCm zdfzlPT1kQ9SJkcZ04LHy6G3N6ubBsulLmi6oeW8g25YqGhDC5/AFmiB8eHtxvl7TaLy/2UGluX cn/t9an+cgGjJf01hQQ== X-Proofpoint-ORIG-GUID: oo-GzwG3lPQmsYqR2Ko-ZL81UNbuyvlR X-Proofpoint-GUID: oo-GzwG3lPQmsYqR2Ko-ZL81UNbuyvlR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-17_01,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602170103 On 2/11/26 11:41 AM, Rakesh Kota wrote: > On Tue, Feb 10, 2026 at 09:32:18AM +0100, Krzysztof Kozlowski wrote: >> On 10/02/2026 09:26, Rakesh Kota wrote: >>> On Mon, Feb 09, 2026 at 02:49:24PM +0100, Krzysztof Kozlowski wrote: >>>> On 09/02/2026 14:23, Rakesh Kota wrote: >>>>> Add the compatible string "qcom,pmm8654au-pon" for the PMM8654AU PMIC. >>>>> The PON peripheral on PMM8654AU is compatible with PMK8350, so it is >>>>> documented as a fallback to "qcom,pmk8350-pon". >>>> >>>> Drop everything after ,. Do not explain WHAT you did. We see it. >>>> >>>>> >>>>> While PMM8654AU supports additional registers compared to the baseline, >>>> >>>> full stop. >>>> >>>>> there is currently no active use case for these features. This specific >>>>> compatible string reserves the identifier for future hardware-specific >>>>> handling if required. >>>> >>>> All the rest is irrelevant or even wrong. We do not reserve identifiers. >>>> If you want to reserve something, then I need to reject the patch. >>>> >>> Hi Konrad Dybcio, >>> >>> It appears that Krzysztof Kozlowski has concerns regarding the >>> compatible string reservation for future use cases, noting that >>> identifiers should not be reserved in this manner. >> >> So do not reserve identifiers but submit bindings reflecting REAL >> hardware being used. >> > Yes, there is a real hardware difference between the PMK8350 and > PMM865AU PON peripherals. The PMM865AU PON is leveraged from the PMK8350 > PON and includes extra features, but those features do not have any > active use cases for now. > > If you are okay with the new compatible string, I will send V3 and fix > the commit message suggestions. I believe the only issue here is the commit message indeed, you're not reserving an identifier, but rather describing a new version/implementation of a hardware block that (with the 8350 fallback) just happens not to need any specific handling to make use of the 99.9% of its features Konrad