From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754183AbcHSBAj (ORCPT ); Thu, 18 Aug 2016 21:00:39 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:36240 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753952AbcHSBAg (ORCPT ); Thu, 18 Aug 2016 21:00:36 -0400 Subject: Re: [PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of() To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1471529868-13669-1-git-send-email-javier@osg.samsung.com> Cc: Amitkumar Karwar , Kalle Valo , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Nishant Sarmukadam From: Arend van Spriel Message-ID: <10fb1110-4c0b-00a2-522c-7011ca397b8c@broadcom.com> Date: Thu, 18 Aug 2016 21:14:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1471529868-13669-1-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18-08-16 16:17, Javier Martinez Canillas wrote: > If request_irq() fails in mwifiex_sdio_probe_of(), only an error message > is printed but the actual error is not propagated to the caller function. Hmm. The caller function, ie. mwifiex_sdio_probe(), does not seem to care. The device may still function without this wake interrupt. Regards, Arend > Signed-off-by: Javier Martinez Canillas > --- > > drivers/net/wireless/marvell/mwifiex/sdio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c > index d3e1561ca075..00727936ad6e 100644 > --- a/drivers/net/wireless/marvell/mwifiex/sdio.c > +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c > @@ -125,6 +125,7 @@ static int mwifiex_sdio_probe_of(struct device *dev, struct sdio_mmc_card *card) > dev_err(dev, > "Failed to request irq_wifi %d (%d)\n", > cfg->irq_wifi, ret); > + return ret; > } > disable_irq(cfg->irq_wifi); > } >