mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Keith Owens <kaos@ocs.com.au>
To: Andrew Morton <akpm@zip.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] block/IDE/interrupt lockup
Date: Sun, 31 Mar 2002 09:23:23 +1000	[thread overview]
Message-ID: <11003.1017530603@ocs3.intra.ocs.com.au> (raw)
In-Reply-To: Your message of "Sat, 30 Mar 2002 11:06:25 PST." <3CA60CB1.E33080D5@zip.com.au>

On Sat, 30 Mar 2002 11:06:25 -0800, 
Andrew Morton <akpm@zip.com.au> wrote:
>What I'd like is a debugging function `can_sleep()'.  This
>is good for documentary purposes, and will catch bugs.
>
>So kmalloc() would gain:
>
>	if (gfp_flags & __GFP_WAIT)
>		can_sleep();

can_sleep_if(gfp_flags & __GFP_WAIT) would be better.  can_sleep_if()
is 
  do { } while(0)
for no debugging, for debugging it is
  if (unlikely(condition)) {
  	whine(__stringify(condition))
  }

One line instead of two, no references to variables when debugging is
off, automatically adds unlikely.


  reply	other threads:[~2002-03-30 23:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-30  9:35 Manfred Spraul
2002-03-30 18:28 ` Andrew Morton
2002-03-30 18:52   ` Alan Cox
2002-03-30 19:06     ` Andrew Morton
2002-03-30 23:23       ` Keith Owens [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-04-01  9:23 Manfred Spraul
2002-03-30  5:45 Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11003.1017530603@ocs3.intra.ocs.com.au \
    --to=kaos@ocs.com.au \
    --cc=akpm@zip.com.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®