From: Rusty Russell <rusty@rustcorp.com.au>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: yiding_wang@agilent.com, doogie@debian.org, arjan@infradead.org,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] handle quoted module parameters
Date: Mon, 15 Nov 2004 11:18:18 +1100 [thread overview]
Message-ID: <1100477898.7381.8.camel@localhost.localdomain> (raw)
In-Reply-To: <41968935.30701@osdl.org>
On Sat, 2004-11-13 at 14:22 -0800, Randy.Dunlap wrote:
> yiding_wang@agilent.com wrote:
> >>There is *no* difference between:
> >>foo="111 222 333"\ 444' 555'
> >>and
> >>foo='111 222 333 444 555'
> >>and
> >>foo="111 222 333 444 555'
> >
> >
> > But there is a difference between foo="111 222 333" and "foo=111 222 333". The new patch is changing from former to later.
>
> Actually the patch allows (or _should allow_) either format for quote
> marks. I didn't remove the older code, just added support for the
> case of quote marks as "foo=this is a test".
Yes, I have no fundamental problem with the patch, but it'd need
thorough testing (eg. with __setup) since this area has broken before.
> Why is the module param length limit of 1024 a problem?
The 1024 test is there because we want to limit how much we output
through sysfs. We could up it to PAGE_SIZE-1.
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman
next prev parent reply other threads:[~2004-11-15 0:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-12 21:57 yiding_wang
[not found] ` <41968935.30701@osdl.org>
2004-11-15 0:18 ` Rusty Russell [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-11-18 19:52 yiding_wang
2004-11-12 19:02 yiding_wang
2004-11-12 19:41 ` Adam Heath
2004-11-11 18:09 module tool with 2.6.9 limitation issue yiding_wang
2004-11-12 4:08 ` Randy.Dunlap
2004-11-12 4:16 ` [PATCH] handle quoted module parameters Randy.Dunlap
2004-11-15 1:14 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1100477898.7381.8.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=doogie@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
--cc=yiding_wang@agilent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome