mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: john stultz <johnstul@us.ibm.com>
To: Andries Brouwer <Andries.Brouwer@cwi.nl>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] __init and i386 timers
Date: Mon, 15 Nov 2004 11:04:59 -0800	[thread overview]
Message-ID: <1100545499.21267.29.camel@cog.beaverton.ibm.com> (raw)
In-Reply-To: <20041113232203.GA23484@apps.cwi.nl>

On Sat, 2004-11-13 at 15:22, Andries Brouwer wrote:
> The i386 timers use a struct timer_opts that has a field init
> pointing at a __init function. The rest of the struct is not __init.
> 
> Nothing is wrong, but if we want to avoid having references to init stuff
> in non-init sections, some reshuffling is needed.

Ugh. I understand the goal, but the resulting code indirection turns my
stomach a bit. 

Although do take my criticism lightly, as right off I don't have a
better suggestion other then to just yank the __init attribute from the
initialization functions. I'm just not sure the savings is worth the
added staple-gunned complexity. Might there be a better way?

thanks
-john


  reply	other threads:[~2004-11-15 19:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-13 23:22 Andries Brouwer
2004-11-15 19:04 ` john stultz [this message]
2004-11-16  9:20   ` Tim Schmielau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1100545499.21267.29.camel@cog.beaverton.ibm.com \
    --to=johnstul@us.ibm.com \
    --cc=Andries.Brouwer@cwi.nl \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®