From: Arjan van de Ven <arjan@infradead.org>
To: Justin Thiessen <jthiessen@penguincomputing.com>
Cc: greg@kroah.com, phil@netroedge.com, khali@linux-fr.org,
sensors@Stimpy.netroedge.com, linux-kernel@vger.kernel.org
Subject: Re: adm1026 driver port for kernel 2.6.10-rc2 [RE-REVISED DRIVER]
Date: Mon, 22 Nov 2004 22:00:42 +0100 [thread overview]
Message-ID: <1101157242.2813.34.camel@laptop.fenrus.org> (raw)
In-Reply-To: <20041122194327.GB4698@penguincomputing.com>
> > this locking construct is rahter awkward; is it possible to refactor the
> > code such that you can down and up in the same function ?
>
> Yes, at the cost of some minor code duplication or the introduction of
> another variable. Is that preferable? Is holding the lock across function
> calls a Bad Idea?
holding lock across function calls isn't, unlocking in another function than you take the lock is.
For one it makes auditing the code a lot harder.
next prev parent reply other threads:[~2004-11-22 21:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20041025210057.GB19053@penguincomputing.com>
[not found] ` <GNXY8AG6.1098776962.4770080.khali@gcu.info>
[not found] ` <20041029191229.GB803@penguincomputing.com>
2004-11-02 16:46 ` adm1026 driver port for kernel 2.6.X - [REVISED DRIVER] Justin Thiessen
2004-11-02 19:31 ` Jean Delvare
2004-11-02 22:17 ` Justin Thiessen
2004-11-03 8:01 ` Jean Delvare
2004-11-03 16:43 ` adm1026 driver port for kernel 2.6.X - [RE-REVISED DRIVER] Justin Thiessen
2004-11-16 18:56 ` Jean Delvare
2004-11-18 18:56 ` adm1026 driver port for kernel 2.6.10-rc2 " Justin Thiessen
2004-11-20 9:57 ` Jean Delvare
2004-11-22 19:35 ` Justin Thiessen
2004-11-20 10:13 ` Arjan van de Ven
2004-11-20 10:32 ` Jean Delvare
2004-11-22 19:43 ` Justin Thiessen
2004-11-22 21:00 ` Arjan van de Ven [this message]
2004-11-22 21:30 ` linux-os
2004-11-23 17:58 ` Jean Delvare
2004-11-23 16:52 ` adm1026 driver port for kernel 2.6.10-rc2 (patch includes driver, patch to Kconfig, and patch to Makefile) Justin Thiessen
2004-11-23 17:50 ` Jean Delvare
2004-11-24 21:36 ` Greg KH
2004-11-24 23:10 ` adm1026 driver port for kernel 2.6.10-rc2 (patch includes driver, patch to Kconfig, and patch to Makefile) [fixed] Justin Thiessen
2004-11-24 22:35 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1101157242.2813.34.camel@laptop.fenrus.org \
--to=arjan@infradead.org \
--cc=greg@kroah.com \
--cc=jthiessen@penguincomputing.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phil@netroedge.com \
--cc=sensors@Stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®