Hi Keiichiro, > This patch is to fix unnecessary increment of 'i' used to > specify an element of an arry 'envp[]' in firmware_class_hotplug(). > The 'i' is already incremented in add_hotplug_env_var(), actually. you are right. The incrementation is wrong, but it doesn't have any negative effect. However the same applies for the usb_hotplug() function in drivers/usb/core/usb.c. > Signed-off-by: Keiichiro Tokunaga Signed-off-by: Marcel Holtmann Regards Marcel