mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "J.A. Magallon" <jamagallon@able.es>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: cdrecord dev=ATA cannont scanbus as non-root
Date: Tue, 30 Nov 2004 18:29:28 +0000	[thread overview]
Message-ID: <1101839368l.13015l.1l@werewolf.able.es> (raw)
In-Reply-To: <Pine.LNX.4.53.0411301854001.29170@yvahk01.tjqt.qr> (from jengelh@linux01.gwdg.de on Tue Nov 30 18:56:46 2004)


On 2004.11.30, Jan Engelhardt wrote:
> >Err, as it tries to open a device and it does not exist.
> >I tries sequentially
> >hda, hdb, hdc.. up to 256 until it finds something to open.
> >If it exists, but has not permissions, it keeps trying on the next.
> >But if it is not present, cdrecord gives up.
> 
> Reasonable procedure. Albeit, leaky:
> Imagine you use devfs... open()ing something like hd* would probably always
> create a node. Although there is a max on possible, meaningful, nodes,
> someone could use this to fill up /dev with
> ridiculuous amounts of nodes, all of which are to my knowledge in kernel space.
> "Well then, goodbye".
> 
> Luckily, even the very default config does not create arbitrarily nodes, and
> cdrecord doesnot probe arbitr. devices.
> 
> So I guess, yes, cdrecord should probe harder. Preferably by looking into /sys
> when using a 2.6 system.
> 

Patch for cdrecord:

--- cdrtools-2.01/libscg/scsi-linux-ata.c.orig	2004-11-30 19:02:37.929176615 +0100
+++ cdrtools-2.01/libscg/scsi-linux-ata.c	2004-11-30 19:06:11.316213702 +0100
@@ -385,8 +385,6 @@
 						device, f, errno);
 					}
 					return (-2);
-				} else if (errno == ENOENT || errno == ENODEV) {
-					break;
 				}
 			} else {
 				/* ugly hack, make better, when you can. Alex */

--
J.A. Magallon <jamagallon()able!es>     \               Software is like sex:
werewolf!able!es                         \         It's better when it's free
Mandrakelinux release 10.2 (Cooker) for i586
Linux 2.6.10-rc2-jam3 (gcc 3.4.1 (Mandrakelinux 10.1 3.4.1-4mdk)) #1



  reply	other threads:[~2004-11-30 18:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-29 21:33 J.A. Magallon
2004-11-29 21:50 ` Jan Engelhardt
2004-11-29 21:59   ` J.A. Magallon
2004-11-30  6:51     ` Jan Engelhardt
2004-11-30  7:16     ` Jens Axboe
2004-11-30 16:29       ` J.A. Magallon
2004-11-30 17:12       ` J.A. Magallon
2004-11-30 17:37         ` Jan Engelhardt
2004-11-30 17:49           ` J.A. Magallon
2004-11-30 17:56             ` Jan Engelhardt
2004-11-30 18:29               ` J.A. Magallon [this message]
2004-12-01 21:16       ` cdrecord dev=ATA cannont scanbus as non-root [u] Martin Schlemmer [c]
2004-12-02 16:23         ` Radoslaw Szkodzinski
2004-12-02 21:50           ` Martin Schlemmer [c]
2004-12-03  7:35           ` Jan Engelhardt
2004-12-03 11:51             ` Rahul Karnik
2004-12-03 12:06               ` Jan Engelhardt
2004-12-03 12:10                 ` Jens Axboe
2004-12-01 21:56       ` cdrecord dev=ATA cannont scanbus as non-root Markus Plail
2004-12-02  8:07         ` Jens Axboe
2004-12-02 12:51           ` J.A. Magallon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1101839368l.13015l.1l@werewolf.able.es \
    --to=jamagallon@able.es \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®