From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>,
torvalds@osdl.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: PATCH: 2.6.10 - generic IDE return codes and a wrong ifdef
Date: Tue, 28 Dec 2004 22:42:58 +0000 [thread overview]
Message-ID: <1104273777.26131.23.camel@localhost.localdomain> (raw)
This patch updates ide/pci/generic.c to fix the incorrect returns
causing PCI devices to be left reserved wrongly by the driver. It
doesn't contain the other -ac improvements for pci/generic just these
fixes.
Signed-off-by: Alan Cox <alan@redhat.com>
--- ../linux.vanilla-2.6.10/drivers/ide/pci/generic.c 2004-12-25 21:15:34.000000000 +0000
+++ drivers/ide/pci/generic.c 2004-12-28 23:40:35.664503856 +0000
@@ -100,18 +100,18 @@
if (dev->vendor == PCI_VENDOR_ID_UMC &&
dev->device == PCI_DEVICE_ID_UMC_UM8886A &&
(!(PCI_FUNC(dev->devfn) & 1)))
- return 1; /* UM8886A/BF pair */
+ return -ENODEV; /* UM8886A/BF pair */
if (dev->vendor == PCI_VENDOR_ID_OPTI &&
dev->device == PCI_DEVICE_ID_OPTI_82C558 &&
(!(PCI_FUNC(dev->devfn) & 1)))
- return 1;
+ return -EAGAIN;
pci_read_config_word(dev, PCI_COMMAND, &command);
if(!(command & PCI_COMMAND_IO))
{
printk(KERN_INFO "Skipping disabled %s IDE controller.\n", d->name);
- return 1;
+ return -EAGAIN;
}
ide_setup_pci_device(dev, d);
return 0;
reply other threads:[~2004-12-28 23:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1104273777.26131.23.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome