From: David Heidelberg <david@ixit.cz>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: apq8960: reflect that memory node starts at offset 0
Date: Fri, 5 Jul 2024 15:30:30 -0700 [thread overview]
Message-ID: <11042ffd-63e3-4e1a-a674-599842c46238@ixit.cz> (raw)
In-Reply-To: <bfacff27-e3b2-43e8-b50e-3da0f13feb5c@linaro.org>
Can we get this in then?
Thanks
David
On 25/08/2023 04:57, Konrad Dybcio wrote:
> On 12.08.2023 20:32, David Heidelberg wrote:
>> Fixes warning generated by `make qcom-msm8960-cdp.dtb`:
>> arch/arm/boot/dts/qcom-msm8960-cdp.dt.yaml: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 0]]}
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
> But does it really?
>
> i.e., if you boot it on a device and xxd /sys/firmware/devicetree/base/memory
> or decompile /sys/firmware/fdt, is it updated to <0x0 0xsomesize>?
>
> Konrad
>> arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
>> index c10797f3793c..c20f16845a97 100644
>> --- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
>> +++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
>> @@ -47,7 +47,7 @@ L2: l2-cache {
>> };
>> };
>>
>> - memory {
>> + memory@0 {
>> device_type = "memory";
>> reg = <0x0 0x0>;
>> };
--
David Heidelberg
prev parent reply other threads:[~2024-07-05 22:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 18:32 David Heidelberg
2023-08-25 11:57 ` Konrad Dybcio
2024-07-05 22:30 ` David Heidelberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11042ffd-63e3-4e1a-a674-599842c46238@ixit.cz \
--to=david@ixit.cz \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®