From: Arjan van de Ven <arjan@infradead.org>
To: selvakumar nagendran <kernelselva@yahoo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Bug : Out of range ptr error in module indicates bug in slab.c
Date: Thu, 30 Dec 2004 12:18:40 +0100 [thread overview]
Message-ID: <1104405521.4170.10.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20041230105452.26574.qmail@web60605.mail.yahoo.com>
On Thu, 2004-12-30 at 02:54 -0800, selvakumar nagendran wrote:
> else {
> new -> pipe_read_end = fdes[0];
> new -> pipe_write_end = fdes[1];
this is a bug; fdes is a USERSPACE pointer, you cannot directly access
that from kernel space, you need to use copy_from_user() for that.
And note, what you are doing is unreliable, since the user is capable of
changing that information before you log it in your structure, so if you
want to use the data you log for anything security related or for
something that has to be accurate, it's broken...
> while(temp != NULL)
> {
> kfree(temp);
> temp = temp -> next;
> }
that is of course wrong; you free temp and THEN you access it!!
next prev parent reply other threads:[~2004-12-30 11:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-30 10:54 selvakumar nagendran
2004-12-30 11:18 ` Arjan van de Ven [this message]
2004-12-30 12:13 ` Bug_reply " selvakumar nagendran
2004-12-30 12:18 ` Arjan van de Ven
2004-12-31 6:51 ` Interception for a resource based scheduler selvakumar nagendran
2004-12-31 7:48 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1104405521.4170.10.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=kernelselva@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®