From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "M.Baris Demiray" <baris@idealteknoloji.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [2.6.10-ac2] Moxa driver causes compile-time errors
Date: Sun, 02 Jan 2005 14:36:21 +0000 [thread overview]
Message-ID: <1104673453.15004.37.camel@localhost.localdomain> (raw)
In-Reply-To: <41D7D2D5.5090407@idealteknoloji.com>
On Sul, 2005-01-02 at 10:54, M.Baris Demiray wrote:
> Hi,
> latest -ac tree patch ac2 replaces some obsolete save_flags()/cli()
> with spin_lock_irqsave() but there are compile time errors caused by
> seems-like-forgotten-to-add-but-used spinlock_t member in moxa_str
> structure. Attached diff file fixes this error and several other
> warnings.
Its still a work in progress. The moxa driver has been defunct since 2.4
and it's not trivial to ressurrect. The majority of moxa hardware uses
mxser which is now happy. Your changes mostly look sane although they
are not enough.
prev parent reply other threads:[~2005-01-02 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-02 10:54 M.Baris Demiray
2005-01-02 14:36 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1104673453.15004.37.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=baris@idealteknoloji.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome