mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Banks <gnb@melbourne.sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Keith Owens <kaos@sgi.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	OProfile List <oprofile-list@lists.sourceforge.net>
Subject: [PATCH] oprofile: fix ia64 callgraph bug with old gcc
Date: Wed, 05 Jan 2005 20:57:40 +1100	[thread overview]
Message-ID: <1104919059.10291.246.camel@hole.melbourne.sgi.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

G'day,

This patch from Keith Owens fixes a bug in the ia64 port
of oprofile when built without the kdb patch and with a
pre-3.4 gcc.

Greg.
-- 
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.


[-- Attachment #2: oprofile-ia64-gcc-pre-34-fix --]
[-- Type: text/plain, Size: 1110 bytes --]

If you build a standard kernel with gcc < 3.4 then
ia64_spinlock_contention_pre3_4 is defined.  But a standard kernel
does not have ia64_spinlock_contention_pre3_4_end, that label is
only added by the kdb patch.  To get the backtrace profiling with
gcc < 3.4, the _end label needs to be added as part of the kernprof
patch, then I will remove it from kdb.  Send this to akpm.

From: Keith Owens <kaos@sgi.com>
Signed-off-by: Keith Owens <kaos@sgi.com>
Signed-off-by: Greg Banks <gnb@melbourne.sgi.com>

Index: linux/arch/ia64/kernel/head.S
===================================================================
--- linux.orig/arch/ia64/kernel/head.S	2004-10-19 07:54:38.000000000 +1000
+++ linux/arch/ia64/kernel/head.S	2005-01-05 20:37:23.000000000 +1100
@@ -949,6 +949,8 @@ GLOBAL_ENTRY(ia64_spinlock_contention_pr
 (p14)	br.cond.sptk.few .wait
 (p15)	rsm psr.i		// disable interrupts if we reenabled them
 	br.cond.sptk.few b6	// lock is now free, try to acquire
+	.global ia64_spinlock_contention_pre3_4_end	// for kernprof
+ia64_spinlock_contention_pre3_4_end:
 END(ia64_spinlock_contention_pre3_4)
 
 #else

                 reply	other threads:[~2005-01-05  9:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1104919059.10291.246.camel@hole.melbourne.sgi.com \
    --to=gnb@melbourne.sgi.com \
    --cc=akpm@osdl.org \
    --cc=kaos@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oprofile-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®