mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@in.ibm.com>
To: Lukasz Kosewski <lkosewsk@nit.ca>
Cc: Andrew Morton <akpm@osdl.org>,
	Arjan van de Ven <arjan@infradead.org>,
	lkml <linux-kernel@vger.kernel.org>,
	linux scsi <linux-scsi@vger.kernel.org>,
	dipankar sarma <dipankar@in.ibm.com>,
	linux-os@analogic.com,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: SCSI aic7xxx driver: Initialization Failure over a kdump reboot
Date: 07 Jan 2005 22:22:38 +0530	[thread overview]
Message-ID: <1105116758.2688.447.camel@2fwv946.in.ibm.com> (raw)
In-Reply-To: <41DEA2E8.8030701@nit.ca>

On Fri, 2005-01-07 at 20:25, Lukasz Kosewski wrote:
> Lukasz Kosewski wrote:
> > Andrew Morton wrote:
> > 
> >>> looks like the following is happening:
> >>> the controller wants to send an irq (probably from previous life)
> >>> then suddenly the driver gets loaded
> >>> * which registers an irq handler
> >>> * which does pci_enable_device()
> >>> and .. the irq goes through. the irq handler just is not yet 
> >>> expecting this irq, so
> >>> returns "uh dunno not mine"
> >>> the kernel then decides to disable the irq on the apic level
> >>> and then the driver DOES need an irq during init
> >>> ... which never happens.
> >>>

Well, in last 4-5 trials I did not see this problem. Everything is same
except we had just opened the box once to checkout few things.

Probably "noirqdebug" boot time parameter can be a stop gap solution
over a kdump boot, which will make sure irq is not disabled even if
unhandled interrupts are there. Assuming driver will be able to
initialize after this and hence undesired interrupt generation shall be
stopped.

> >>
> >>
> >> yes, that's exactly what e100 was doing on my laptop last month.  Fixed
> >> that by arranging for the NIC to be reset before the call to
> >> pci_set_master().
> 
> After reading this again when I /wasn't/ semi-comatose, I retract my 
> statement insofar as it wouldn't help you (but I think it's still rather 
> necessary) :)
> 
> The system did exactly what I'm talking about (which it didn't do for 
> me, possibly because the board/processor didn't support APIC).  I guess 
> my question to you is:  do you have other devices sharing this 
> interrupt?  In other words, are you /sure/ that it's the adaptec 
> controller which is setting the interrupt line high?

I am not sure about this. Following are two contradictory observations.

1. Remove the adaptec controller support and everything works fine. It
might mean that it was adapted controller only which was generating
spurious interrupts.

2. There are two more SCSI Controllers in the system and first one is
managing all the six hard disks in the system.

05:07.0 SCSI storage controller: LSI Logic / Symbios Logic 53c1030 (rev
07)
05:07.1 SCSI storage controller: LSI Logic / Symbios Logic 53c1030 (rev
07)

These also could be potential source of interrupts as after a successful
reboot with kdump, these also are sharing irq 9.

Following is a snapshot of /proc/interrupts over a kdump boot with
"noirqdebug"

           CPU0       CPU1
  0:     109474          0          XT-PIC  timer
  1:          8          0          XT-PIC  i8042
  2:          0          0          XT-PIC  cascade
  4:        385          0          XT-PIC  serial
  8:          1          0          XT-PIC  rtc
  9:      25588          0          XT-PIC  aic7xxx, ioc0, ioc1
 12:        100          0          XT-PIC  i8042
 14:         19          0          XT-PIC  ide0



In normal boot, I don't see any other device connected to irq 9. (I am
not sure if this irq number can change over reboot)

Following is a snapshot of /proc/interrupts over a normal boot.

           CPU0       CPU1
  0:      95314          0    IO-APIC-edge  timer
  1:          9          0    IO-APIC-edge  i8042
  2:          0          0          XT-PIC  cascade
  4:        498          0    IO-APIC-edge  serial
  8:          2          0    IO-APIC-edge  rtc
 12:        100          0    IO-APIC-edge  i8042
 14:         20          0    IO-APIC-edge  ide0
 18:       1155          0   IO-APIC-level  eth0
 24:         30          0   IO-APIC-level  aic7xxx
 27:       1946          0   IO-APIC-level  ioc0
 28:         29          0   IO-APIC-level  ioc1
NMI:          0          0
LOC:      94835      96567
ERR:          0
MIS:          0


Does that conclude anything that who is/was the potential source?

Vivek



  parent reply	other threads:[~2005-01-07 16:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-06 12:35 Vivek Goyal
2005-01-06 12:12 ` Arjan van de Ven
2005-01-07  3:50   ` Andrew Morton
2005-01-07  4:53     ` Lukasz Kosewski
2005-01-07  4:38       ` Matthew Wilcox
2005-01-30 15:27         ` Marcelo Tosatti
2005-01-30 18:27           ` Arjan van de Ven
2005-01-30 15:57             ` Marcelo Tosatti
2005-01-07  7:36       ` Vivek Goyal
2005-01-07 14:55       ` Lukasz Kosewski
2005-01-07 14:50         ` linux-os
2005-01-07 15:44           ` Vivek Goyal
2005-01-07 16:52         ` Vivek Goyal [this message]
2005-01-07 17:36       ` Denis Vlasenko
2005-01-07  5:27     ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1105116758.2688.447.camel@2fwv946.in.ibm.com \
    --to=vgoyal@in.ibm.com \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=dipankar@in.ibm.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-os@analogic.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lkosewsk@nit.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®