mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steve French <smfltc@us.ibm.com>
To: maxk@qualcomm.com, linux-kernel@vger.kernel.org
Cc: underley@underley.eu.org
Subject: [PATCH] missing dependency for drivers/net/tun.c
Date: 11 Jan 2005 15:06:12 -0600	[thread overview]
Message-ID: <1105477572.12905.16.camel@stevef95.austin.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

drivers/net/tun.c has a missing dependency on enabling the crc32
libraries in kernel config.   With tun enabled and crc32 disabled "make
bzImage" (the linking step) fails. For example:

drivers/built-in.o(.text+0x656f1): In function `add_multi':
linux-2.5cifs/drivers/net/tun.c:112: undefined reference to `crc32_le'
drivers/built-in.o(.text+0x656f9):linux-2.5cifs/drivers/net/tun.c:112:
undefined reference to `bitreverse'

Line 112:

	        int bit_nr = ether_crc(ETH_ALEN, addr) >> 26;

is a call to the ether_crc macro which maps to the bitreverse function
which is only exported if you enable:
	library functions -> CRC32 functions 
in kernel config.  The following would fix it.




[-- Attachment #2: tun-config.patch --]
[-- Type: text/plain, Size: 400 bytes --]

--- drivers/net/Kconfig.old	2005-01-11 14:59:51.540023800 -0600
+++ drivers/net/Kconfig	2005-01-11 15:00:48.126421360 -0600
@@ -84,6 +84,7 @@
 config TUN
 	tristate "Universal TUN/TAP device driver support"
 	depends on NETDEVICES
+	select CRC32
 	---help---
 	  TUN/TAP provides packet reception and transmission for user space
 	  programs.  It can be viewed as a simple Point-to-Point or Ethernet

             reply	other threads:[~2005-01-11 21:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-11 21:06 Steve French [this message]
2005-01-12 21:44 ` Max Krasnyansky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1105477572.12905.16.camel@stevef95.austin.ibm.com \
    --to=smfltc@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxk@qualcomm.com \
    --cc=underley@underley.eu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®