From: Daniel Baluta <daniel.baluta@nxp.com>
To: "festevam@gmail.com" <festevam@gmail.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Aisheng Dong <aisheng.dong@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Anson Huang <anson.huang@nxp.com>,
"S.j. Wang" <shengjiu.wang@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Subject: Re: [PATCH] arm64: dts: imx: Fix MU4_INT number
Date: Wed, 16 Jan 2019 13:24:49 +0000 [thread overview]
Message-ID: <11058ce79d91a49e47be47bd369ddc111875fa23.camel@nxp.com> (raw)
In-Reply-To: <CAOMZO5D_kakB82dEcXrU4EZARLj90US8Zf+sGgaKkZvUG3t=PA@mail.gmail.com>
On Wed, 2019-01-16 at 11:12 -0200, Fabio Estevam wrote:
> Hi Daniel,
>
> On Tue, Jan 15, 2019 at 3:05 PM Daniel Baluta <daniel.baluta@nxp.com>
> wrote:
> >
> > MU4_INT correct number is 180, while 179 is for MU3_INT.
> >
> > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
>
> Two nitpicks:
>
> 1. In the Subject it would be better to specify the SoC name:
> arm64: dts: imx8qxp: Fix MU4_INT number
>
> 2. It would be nice to add a Fixes tag
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Thanks Fabio for review. Fixed in v2.
prev parent reply other threads:[~2019-01-16 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 17:05 Daniel Baluta
2019-01-16 9:28 ` Aisheng Dong
2019-01-16 13:12 ` Fabio Estevam
2019-01-16 13:24 ` Daniel Baluta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11058ce79d91a49e47be47bd369ddc111875fa23.camel@nxp.com \
--to=daniel.baluta@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®