From: Matthew Dobson <colpatch@us.ibm.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>, Dave Hansen <haveblue@us.ibm.com>,
Andy Whitcroft <andyw@uk.ibm.com>,
Patrick Mansfield <patmans@us.ibm.com>
Subject: Re: [PATCH] Fix num_online_nodes() warning on NUMA-Q
Date: Wed, 19 Jan 2005 15:15:42 -0800 [thread overview]
Message-ID: <1106176542.9732.18.camel@arrakis> (raw)
In-Reply-To: <1106158027.5548.15.camel@arrakis>
On Wed, 2005-01-19 at 10:07, Matthew Dobson wrote:
> include/asm-i386/mach-numaq/mach_apic.h complains about an implicit
> declaration of num_online_nodes():
>
> In file included from arch/i386/kernel/cpu/intel.c:19:
> include/asm-i386/mach-numaq/mach_apic.h: In function `setup_portio_remap':
> include/asm-i386/mach-numaq/mach_apic.h:115: warning: implicit declaration of function `num_online_nodes'
>
> This patch gets rid of this warning. Please apply.
>
> -Matt
Another compilation warning/error related to the recent
num_online_nodes() work was discovered. This rollup patch fixes both
the above warning and the warnings/errors in arch/i386/pci/numa.c
discovered by Pat Mansfield.
-Matt
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.11-rc1-mm1/arch/i386/pci/numa.c linux-2.6.11-rc1-mm1+warn_fix/arch/i386/pci/numa.c
--- linux-2.6.11-rc1-mm1/arch/i386/pci/numa.c 2005-01-18 11:28:33.000000000 -0800
+++ linux-2.6.11-rc1-mm1+warn_fix/arch/i386/pci/numa.c 2005-01-19 15:07:24.000000000 -0800
@@ -4,6 +4,7 @@
#include <linux/pci.h>
#include <linux/init.h>
+#include <linux/nodemask.h>
#include "pci.h"
#define BUS2QUAD(global) (mp_bus_id_to_node[global])
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.11-rc1-mm1/include/asm-i386/mach-numaq/mach_apic.h linux-2.6.11-rc1-mm1+warn_fix/include/asm-i386/mach-numaq/mach_apic.h
--- linux-2.6.11-rc1-mm1/include/asm-i386/mach-numaq/mach_apic.h 2005-01-18 11:29:06.000000000 -0800
+++ linux-2.6.11-rc1-mm1+warn_fix/include/asm-i386/mach-numaq/mach_apic.h 2005-01-18 15:57:33.000000000 -0800
@@ -3,6 +3,7 @@
#include <asm/io.h>
#include <linux/mmzone.h>
+#include <linux/nodemask.h>
#define APIC_DFR_VALUE (APIC_DFR_CLUSTER)
prev parent reply other threads:[~2005-01-19 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-19 18:07 Matthew Dobson
2005-01-19 23:15 ` Matthew Dobson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1106176542.9732.18.camel@arrakis \
--to=colpatch@us.ibm.com \
--cc=akpm@osdl.org \
--cc=andyw@uk.ibm.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patmans@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®