From: David Woodhouse <dwmw2@infradead.org>
To: Greg KH <greg@kroah.com>
Cc: John Mock <kd6pag@qsl.net>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.11-rc1 vs. PowerMac 8500/G3 (and VAIO laptop) [usb-storage oops]
Date: Fri, 21 Jan 2005 08:12:16 +0000 [thread overview]
Message-ID: <1106295136.783.47.camel@baythorne.infradead.org> (raw)
In-Reply-To: <20050121075833.GA19995@kroah.com>
On Thu, 2005-01-20 at 23:58 -0800, Greg KH wrote:
> Well, we should be byteswapping all of the fields that need to be
> swapped, right? I'm guessing that userspace is expecting the fields
> to be in cpu endian, correct?
Userspace varies in that. Nobody expects _all_ the fields to be swapped;
the kernel only ever swapped those four. And in fact lsusb from the
stock usbutils expects it to be consistently little-endian. John's
version seems to be hacked to expect just those four fields to be host-
endian, while the rest remains little-endian.
We have a choice here -- we can preserve the ABI by continuing to be
stupidly inconsistent about endianness, or you can revert my patch and
stock usbutils can be correct.
> But if you want, I'll gladly revert your patch, as I don't have a ppc
> box to test this out on.
I'd revert it.
--
dwmw2
next prev parent reply other threads:[~2005-01-21 8:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-19 23:39 John Mock
2005-01-20 8:40 ` David Woodhouse
2005-01-21 0:08 ` Greg KH
2005-01-21 7:49 ` David Woodhouse
2005-01-21 7:58 ` Greg KH
2005-01-21 8:12 ` David Woodhouse [this message]
2005-01-21 8:42 ` Greg KH
2005-01-20 18:29 John Mock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1106295136.783.47.camel@baythorne.infradead.org \
--to=dwmw2@infradead.org \
--cc=greg@kroah.com \
--cc=kd6pag@qsl.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome