From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linux NICS <linux.nics@intel.com>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] e100 locking up netconsole.
Date: Sat, 22 Jan 2005 20:52:26 -0500 [thread overview]
Message-ID: <1106445146.11995.36.camel@localhost.localdomain> (raw)
I'm currently working with Ingo's RT patched kernel, but I believe this
affects the mainline too.
If the transmit buffer of the e100 overflowed, then the system would
hang. This was caused because the e100 driver would stop the queue, and
find_skb in netpoll.c would then loop forever. This is because the e100
net_poll would never start the queue again after the transmits have
completed.
For those that use the e100 and netconsole, all you need to do is a
sysreq 't' to lock up the system.
Here's the patch: (from Ingo's linux-2.6.11-rc2-V0.7.36-02, but should
be OK with 2.6.11-rc2)
Index: drivers/net/e100.c
===================================================================
--- drivers/net/e100.c (revision 60)
+++ drivers/net/e100.c (working copy)
@@ -1630,6 +1630,7 @@
struct nic *nic = netdev_priv(netdev);
e100_disable_irq(nic);
e100_intr(nic->pdev->irq, netdev, NULL);
+ e100_tx_clean(nic);
e100_enable_irq(nic);
}
#endif
-- Steve
next reply other threads:[~2005-01-23 1:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-23 1:52 Steven Rostedt [this message]
2005-01-23 3:29 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1106445146.11995.36.camel@localhost.localdomain \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.nics@intel.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome