Re: [RFC][PATCH] new timeofday arch specific timesources (v. A2)

[john stultz <johnstul@us.ibm.com>]

On Mon, 2005-01-24 at 15:29 -0800, Christoph Lameter wrote:
> On Mon, 24 Jan 2005, john stultz wrote:
> 
> > +/* helper macro to atomically read both cyclone counter registers */
> > +#define read_cyclone_counter(low,high) \
> > +	do{ \
> > +		high = cyclone_timer[1]; low = cyclone_timer[0]; \
> > +	} while (high != cyclone_timer[1]);
> 
> This is only necessary on 32 bit platforms. On ia64 an atomic read would
> do the job. Maybe that logic needs to go into the custom defined readq for
> 32 bit? Then you could avoid repeating the code for drivers that read 64
> bit clocks on 32bit processors.

Yea, I still need to convert the cyclone timesource to an
TIMESOURCE_MMIO_64. Hopefully I'll get to that in the next release.

thanks again for the review and feedback!
-john