From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261251AbVBFRjr (ORCPT ); Sun, 6 Feb 2005 12:39:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261253AbVBFRjr (ORCPT ); Sun, 6 Feb 2005 12:39:47 -0500 Received: from canuck.infradead.org ([205.233.218.70]:37898 "EHLO canuck.infradead.org") by vger.kernel.org with ESMTP id S261251AbVBFRji (ORCPT ); Sun, 6 Feb 2005 12:39:38 -0500 Subject: Re: [PROPOSAL/PATCH] Remove PT_GNU_STACK support before 2.6.11 From: Arjan van de Ven To: Linus Torvalds Cc: Andi Kleen , Ingo Molnar , Christoph Hellwig , akpm@osdl.org, linux-kernel@vger.kernel.org, drepper@redhat.com In-Reply-To: References: <20050206120244.GA28061@elte.hu> <20050206124523.GA762@elte.hu> <20050206125002.GF30109@wotan.suse.de> <1107694800.22680.90.camel@laptopd505.fenrus.org> <20050206130152.GH30109@wotan.suse.de> <20050206130650.GA32015@infradead.org> <20050206131130.GJ30109@wotan.suse.de> <20050206133239.GA4483@elte.hu> <20050206134640.GB30476@wotan.suse.de> <20050206140802.GA6323@elte.hu> <20050206142936.GC30476@wotan.suse.de> <1107710023.22680.138.camel@laptopd505.fenrus.org> Content-Type: text/plain Date: Sun, 06 Feb 2005 18:39:28 +0100 Message-Id: <1107711569.22680.146.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.0.2 (2.0.2-3) Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-Spam-Report: SpamAssassin version 2.63 on canuck.infradead.org summary: Content analysis details: (0.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.3 RCVD_NUMERIC_HELO Received: contains a numeric HELO X-SRS-Rewrite: SMTP reverse-path rewritten from by canuck.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2005-02-06 at 09:31 -0800, Linus Torvalds wrote: > > On Sun, 6 Feb 2005, Arjan van de Ven wrote: > > > > Note that these techniques all exist today. The only issue is that the > > current code doesn't do the RWE->READIMPLIESEXEC binding, which my patch > > fixed. > > My main objection to your patch is the naming. If 'executable_stack' > affects the heap, then why is it called "executable_STACK"? fair point. > > Wouldn't it be much nicer to > > - get rid of "EXSTACK_DEFAULT" as a special case, and instead just have > the architecture _initialize_ the damn variable to what it wants? In > other words, make it a nice understandable binary value (or maybe a > bitmask, if you want to have separate flags for stack/heap/mmap), > rather than a ternary value where one of the values means something > arch-dependent. > > - just rename the dang thing to "read_implies_exec" and be done with it? > > Hmm? Wouldn't that make a lot more sense? it would. It'll be a bit bigger than I'd be comfortable with this late in the 2.6.11 cycle though. > > And if you want to split things up, there's at least three flags there: > "stack" vs "file mapping" vs "anonymous mapping". For example, it might lets add "brk" as 4th I guess. Ok so what to do for 2.6.11... the setarch workaround is there; that works. My patch patches the worst issues and is quite minimal. What you propose will be more invasive and more suitable for 2.6.11-bk1... I can do such a patch no problem (although the next two days I won't have time).