mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Blunck <j.blunck@tu-harburg.de>
To: Alex Tomas <alex@clusterfs.com>
Cc: Alexander Viro <viro@parcelfarce.linux.theplanet.co.uk>,
	Linux-Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC] pdirops: vfs patch
Date: Tue, 22 Feb 2005 14:00:22 +0100	[thread overview]
Message-ID: <1109077222.421b2ce6739f8@webmail.tu-harburg.de> (raw)
In-Reply-To: <m3vf8kx0ll.fsf@bzzz.home.net>

Quoting Alex Tomas <alex@clusterfs.com>:

> >>>>> Jan Blunck (JB) writes:
>
>  >> 1) i_sem protects dcache too
>
>  JB> Where? i_sem is the per-inode lock, and shouldn't be used else.
>
> read comments in fs/namei.c:read_lookup()
>

i_sem does NOT protect the dcache. Also not in real_lookup(). The lock must be
acquired for ->lookup() and because we might sleep on i_sem, we have to get it
early and check for repopulation of the dcache.

> we've already done this for ext3. it works.
> it speeds some loads up significantly.
> especially on big directories.
> and you can control this via mount option,
> so almost zero cost for fs that doesn't support pdirops.

Ok.

Jan

  reply	other threads:[~2005-02-22 13:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-22 11:54 Jan Blunck
2005-02-22 12:04 ` Alex Tomas
2005-02-22 13:00   ` Jan Blunck [this message]
2005-02-22 13:23     ` Alex Tomas
2005-02-22 13:41       ` Jan Blunck
2005-02-23 13:55         ` Alex Tomas
  -- strict thread matches above, loose matches on Subject: below --
2005-02-19 17:57 [RFC] parallel directory operations Alex Tomas
2005-02-19 18:04 ` [RFC] pdirops: vfs patch Alex Tomas
2005-02-20 23:35   ` Jan Blunck
2005-02-20 23:43     ` Alex Tomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1109077222.421b2ce6739f8@webmail.tu-harburg.de \
    --to=j.blunck@tu-harburg.de \
    --cc=alex@clusterfs.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®