mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jim Houston <jim.houston@ccur.com>
To: russell@coker.com.au
Cc: linux-kernel@vger.kernel.org
Subject: Re: idr_remove
Date: 22 Feb 2005 13:22:46 -0500	[thread overview]
Message-ID: <1109096566.1010.53.camel@new.localdomain> (raw)
In-Reply-To: <200502192332.54815.russell@coker.com.au>

On Sat, 2005-02-19 at 07:32, Russell Coker wrote:
> http://marc.theaimsgroup.com/?l=linux-kernel&m=109838483518162&w=2
> 
> I am getting messages "idr_remove called for id=0 which is not allocated" when 
> SE Linux denies search access to /dev/pts.
> 
> The attached file has some klogd output showing the situation, triggered in 
> this case by installing a new kernel package on a SE Debian system.  The 
> above URL references Jim Houston's message with the patch to add this 
> warning.

Hi Russell, Everyone,

I believe that the warning is correct.  It is intended to catch
the case where an id is freed without being allocated.  The most
likely case is the teardown of the pty is calling idr_remove()
twice for the same id value.  The other possible case is that
an id has not been allocated and idr_remove() is being called
by mistake.  

I spent time looking at the pty and selinux code yesterday.
I had little luck finding where the selinux code hooks into 
the pty code.

I have not used selinux.  I have a recent Fedora FC3 install but I
didn't enable selinux.  If you can give me cookbook directions,
I will try to reproduce the problem here.

I was hoping that changing the file permissions on /dev/pts might
produce the same effect.  It prevent xterm from opening the pty but
it didn't cause the idr_remove() warning.

Jim Houston - Concurrent Computer Corp.


  parent reply	other threads:[~2005-02-22 18:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-19 12:32 idr_remove Russell Coker
2005-02-22 17:35 ` idr_remove Lorenzo Hernández García-Hierro
2005-02-22 18:22 ` Jim Houston [this message]
2005-02-22 18:32   ` idr_remove Stephen Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1109096566.1010.53.camel@new.localdomain \
    --to=jim.houston@ccur.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=russell@coker.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®