From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/13] timestamp fixes
Date: Thu, 24 Feb 2005 18:16:02 +1100 [thread overview]
Message-ID: <1109229362.5177.67.camel@npiggin-nld.site> (raw)
In-Reply-To: <1109229293.5177.64.camel@npiggin-nld.site>
[-- Attachment #1: Type: text/plain, Size: 6 bytes --]
1/13
[-- Attachment #2: sched-timestamp-fixes.patch --]
[-- Type: text/x-patch, Size: 1377 bytes --]
Some fixes for unsynchronised TSCs. A task's timestamp may have been set
by another CPU. Although we try to adjust this correctly with the
timestamp_last_tick field, there is no guarantee this will be exactly right.
Signed-off-by: Nick Piggin <nickpiggin@yahoo.com.au>
Index: linux-2.6/kernel/sched.c
===================================================================
--- linux-2.6.orig/kernel/sched.c 2005-02-24 17:31:25.384986289 +1100
+++ linux-2.6/kernel/sched.c 2005-02-24 17:43:39.356379395 +1100
@@ -648,6 +648,7 @@
static void recalc_task_prio(task_t *p, unsigned long long now)
{
+ /* Caller must always ensure 'now >= p->timestamp' */
unsigned long long __sleep_time = now - p->timestamp;
unsigned long sleep_time;
@@ -2703,8 +2704,10 @@
schedstat_inc(rq, sched_cnt);
now = sched_clock();
- if (likely(now - prev->timestamp < NS_MAX_SLEEP_AVG))
+ if (likely((long long)now - prev->timestamp < NS_MAX_SLEEP_AVG))
run_time = now - prev->timestamp;
+ if (unlikely((long long)now - prev->timestamp < 0))
+ run_time = 0;
else
run_time = NS_MAX_SLEEP_AVG;
@@ -2782,6 +2785,8 @@
if (!rt_task(next) && next->activated > 0) {
unsigned long long delta = now - next->timestamp;
+ if (unlikely((long long)now - next->timestamp < 0))
+ delta = 0;
if (next->activated == 1)
delta = delta * (ON_RUNQUEUE_WEIGHT * 128 / 100) / 128;
next prev parent reply other threads:[~2005-02-24 7:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-24 7:14 [PATCH 0/13] Multiprocessor CPU scheduler patches Nick Piggin
2005-02-24 7:16 ` Nick Piggin [this message]
2005-02-24 7:16 ` [PATCH 2/13] improve pinned task handling Nick Piggin
2005-02-24 7:18 ` [PATCH 3/13] rework schedstats Nick Piggin
2005-02-24 7:19 ` [PATCH 4/13] find_busiest_group fixlets Nick Piggin
2005-02-24 7:20 ` [PATCH 5/13] find_busiest_group cleanup Nick Piggin
2005-02-24 7:21 ` [PATCH 6/13] no aggressive idle balancing Nick Piggin
2005-02-24 7:22 ` [PATCH 7/13] better active balancing heuristic Nick Piggin
2005-02-24 7:24 ` [PATCH 8/13] generalised CPU load averaging Nick Piggin
2005-02-24 7:25 ` [PATCH 9/13] less affine wakups Nick Piggin
2005-02-24 7:27 ` [PATCH 10/13] remove aggressive idle balancing Nick Piggin
2005-02-24 7:28 ` [PATCH 11/13] sched-domains aware balance-on-fork Nick Piggin
2005-02-24 7:28 ` [PATCH 12/13] schedstats additions for sched-balance-fork Nick Piggin
2005-02-24 7:30 ` [PATCH 13/13] basic tuning Nick Piggin
2005-02-24 8:46 ` [PATCH 12/13] schedstats additions for sched-balance-fork Ingo Molnar
2005-02-24 22:13 ` Nick Piggin
2005-02-25 11:07 ` Rick Lindsley
2005-02-25 11:21 ` Nick Piggin
2005-02-24 8:41 ` [PATCH 10/13] remove aggressive idle balancing Ingo Molnar
2005-02-24 12:13 ` Nick Piggin
2005-02-24 12:16 ` Ingo Molnar
2005-03-06 5:43 ` Siddha, Suresh B
2005-03-07 5:34 ` Nick Piggin
2005-03-07 8:04 ` Siddha, Suresh B
2005-03-07 8:28 ` Nick Piggin
2005-03-08 7:22 ` Siddha, Suresh B
2005-03-08 8:17 ` Nick Piggin
2005-03-08 19:36 ` Siddha, Suresh B
2005-02-24 8:39 ` [PATCH 7/13] better active balancing heuristic Ingo Molnar
2005-02-24 8:36 ` [PATCH 4/13] find_busiest_group fixlets Ingo Molnar
2005-02-24 8:07 ` [PATCH 3/13] rework schedstats Ingo Molnar
2005-02-25 10:50 ` Rick Lindsley
2005-02-25 11:10 ` Nick Piggin
2005-02-25 11:25 ` DHCP on multi homed host! Ravindra Nadgauda
2005-02-24 8:04 ` [PATCH 2/13] improve pinned task handling Ingo Molnar
2005-02-24 7:46 ` [PATCH 1/13] timestamp fixes Ingo Molnar
2005-02-24 7:56 ` Nick Piggin
2005-02-24 8:34 ` Ingo Molnar
[not found] <42235517.5070504@us.ibm.com>
2005-02-28 18:11 ` Andrew Theurer
2005-03-01 8:09 ` Nick Piggin
2005-03-01 9:03 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1109229362.5177.67.camel@npiggin-nld.site \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®