From: Arjan van de Ven <arjan@infradead.org>
To: Gerrit Huizenga <gh@us.ibm.com>
Cc: Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org, akpm@osdl.org,
Rik van Riel <riel@redhat.com>, Chris Mason <mason@suse.com>,
ckrm-tech <ckrm-tech@lists.sourceforge.net>
Subject: Re: [PATCH] CKRM: 4/10 CKRM: Full rcfs support
Date: Thu, 24 Feb 2005 10:59:01 +0100 [thread overview]
Message-ID: <1109239142.6530.27.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <E1D4FN0-0006v2-00@w-gerrit.beaverton.ibm.com>
On Thu, 2005-02-24 at 01:33 -0800, Gerrit Huizenga wrote:
> > > + if (!access_ok(VERIFY_READ, buf, count))
> > > + return -EFAULT;
> > > + down(&(ri->vfs_inode.i_sem));
> > > + optbuf = kmalloc(TARGET_MAX_INPUT_SIZE, GFP_KERNEL);
> >
> > kmalloc with a lock held? Is that a good idea?
>
> Lock? Or sema? Sema should be okay here, right?
not if that semaphore can be grabbed from a file data write out path...
and the semaphore sounds VFS-ish so it sure makes me nervous.
next prev parent reply other threads:[~2005-02-24 10:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-29 18:48 Gerrit Huizenga
2004-11-29 22:15 ` Greg KH
2005-02-24 9:33 ` Gerrit Huizenga
2005-02-24 9:59 ` Arjan van de Ven [this message]
2005-02-24 17:42 ` Greg KH
2005-02-24 22:25 ` [ckrm-tech] " Shailabh Nagar
2005-02-24 23:25 ` Chris Friesen
2005-02-24 23:59 ` Gerrit Huizenga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1109239142.6530.27.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=ckrm-tech@lists.sourceforge.net \
--cc=gh@us.ibm.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@suse.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®