From: Arjan van de Ven <arjan@infradead.org>
To: Brian Gerst <bgerst@didntduck.org>
Cc: Horst von Brand <vonbrand@inf.utfsm.cl>,
Andrew Morton <akpm@osdl.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vsprintf.c cleanups
Date: Fri, 25 Feb 2005 13:34:27 +0100 [thread overview]
Message-ID: <1109334867.6290.52.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <421F19E4.10600@didntduck.org>
On Fri, 2005-02-25 at 07:28 -0500, Brian Gerst wrote:
> Horst von Brand wrote:
> > Brian Gerst <bgerst@didntduck.org> said:
> >
> >>- Make sprintf call vsnprintf directly
> >>- use INT_MAX for sprintf and vsprintf
> >
> >
> > This is the size limit on what is written. 4GiB sounds a bit extreme...
>
> Sprintf has no limit, which is why it's generally bad to use it. I just
> replaced an open coded ((~0U)>>1) value with the equivalent INT_MAX.
I can see the point of using PAGE_SIZE instead; and if someone really
wants more than that, he/she should use snprintf with a specified
size....
next prev parent reply other threads:[~2005-02-25 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-24 23:16 Brian Gerst
2005-02-25 0:59 ` Horst von Brand
2005-02-25 12:28 ` Brian Gerst
2005-02-25 12:34 ` Arjan van de Ven [this message]
2005-02-25 13:37 ` Horst von Brand
2005-02-27 8:12 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1109334867.6290.52.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=bgerst@didntduck.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vonbrand@inf.utfsm.cl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®