mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nigel Cunningham <ncunningham@cyclades.com>
To: Pavel Machek <pavel@suse.cz>
Cc: Andrew Morton <akpm@osdl.org>,
	mjg59@scrf.ucam.org, hare@suse.de,
	"Barry K. Nathan" <barryn@pobox.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: swsusp: allow resume from initramfs
Date: Sat, 05 Mar 2005 12:07:47 +1100	[thread overview]
Message-ID: <1109984867.3772.322.camel@desktop.cunningham.myip.net.au> (raw)
In-Reply-To: <20050304225556.GA2647@elf.ucw.cz>

Hi.

On Sat, 2005-03-05 at 09:55, Pavel Machek wrote:
> > All that to say "Bitmaps were a definite win!". Perhaps I can sell you
> > on the advantages of using them :>
> 
> Not sure, if one bit goes wrong you put everything in the wrong places
> :-). Linklist seems just okay to me, no > 4K allocations. I'm not sure
> why recalculation is that big problem.

So you make sure all the bits are right :> I can understand you being
happy with linked lists; it's just that they're really inefficient
spacewise. Since you're freeing far more memory at the moment, it's not
an issue.

Regarding recalculation being a problem, I want Suspend to always work.
If you have unpredictable variation, you have a potential source of
failure.

> > By the way, did you see the effect of the memory eating patch? I didn't
> > think about it until someone emailed me, but the improvement was 50x
> > speed in the best case!
> 
> Well, more interesting was that you actually freed much more memory
> with your patch. *You actually made memory freeing to work*. So yes, I
> like that one.

You might be misreading me. When you set the image size limit setting in
Suspend2, it's a soft limit. The image size wouldn't actually get down
to 2 meg; Suspend would just aim for that and eat memory until it saw it
wasn't getting anywhere.

Regards,

Nigel
-- 
Nigel Cunningham
Software Engineer, Canberra, Australia
http://www.cyclades.com
Bus: +61 (2) 6291 9554; Hme: +61 (2) 6292 8028;  Mob: +61 (417) 100 574

Maintainer of Suspend2 Kernel Patches http://softwaresuspend.berlios.de



  reply	other threads:[~2005-03-05  1:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-04 10:16 Pavel Machek
2005-03-04 11:04 ` Andrew Morton
2005-03-04 11:15   ` Pavel Machek
2005-03-04 17:17   ` Stefan Seyfried
2005-03-04 17:50   ` Barry K. Nathan
2005-03-04 21:22     ` Nigel Cunningham
2005-03-04 21:43       ` Pavel Machek
2005-03-04 21:50         ` Nigel Cunningham
2005-03-04 22:07           ` Pavel Machek
2005-03-04 22:31             ` Nigel Cunningham
2005-03-04 22:55               ` Pavel Machek
2005-03-05  1:07                 ` Nigel Cunningham [this message]
2005-03-05 21:58                   ` swsusp memory freeing [was Re: swsusp: allow resume from initramfs] Pavel Machek
2005-03-06 22:28   ` swsusp: allow resume from initramfs Andreas Jellinghaus
2005-03-06 22:27 ` Andreas Jellinghaus
2005-03-07 11:40   ` Pavel Machek
     [not found] <fa.e8vvlml.hjolb5@ifi.uio.no>
     [not found] ` <fa.h2h05q4.mmkqpm@ifi.uio.no>
2005-03-04 13:36   ` Bodo Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1109984867.3772.322.camel@desktop.cunningham.myip.net.au \
    --to=ncunningham@cyclades.com \
    --cc=akpm@osdl.org \
    --cc=barryn@pobox.com \
    --cc=hare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@scrf.ucam.org \
    --cc=pavel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®