From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753989AbbCBLO4 (ORCPT ); Mon, 2 Mar 2015 06:14:56 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:56269 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753619AbbCBLOy (ORCPT ); Mon, 2 Mar 2015 06:14:54 -0500 X-AuditID: cbfee690-f79ab6d0000046f7-06-54f4462ba9c1 Message-id: <110D56A3356F4CB298E0690B183D50F0@sisodomain.com> From: Vivek Gautam To: Axel Lin , Kishon Vijay Abraham I Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org References: <1425051864.6032.1.camel@phoenix> In-reply-to: <1425051864.6032.1.camel@phoenix> Subject: Re: [PATCH] phy: exynos5-usbdrd: Fix off-by-one valid value checking for args->args[0] Date: Mon, 02 Mar 2015 16:41:41 +0530 MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=utf-8; reply-type=original Content-transfer-encoding: 7bit X-Priority: 3 X-MSMail-priority: Normal Importance: Normal X-Mailer: Microsoft Windows Live Mail 14.0.8117.416 X-MIMEOLE: Produced By Microsoft MimeOLE V14.0.8117.416 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBIsWRmVeSWpSXmKPExsWyRsSkWlfH7UuIwbonLBZH5nxltrjwtIfN 4vKuOWwWM87vY3Jg8Wj7WeZx/MZ2Jo/Pm+QCmKO4bFJSczLLUov07RK4MiZdP8pWMI2jYvb7 VcwNjE/Zuhg5OSQETCQun1rADmGLSVy4tx4sLiSwlFFiy8U8mJojq8+ydDFyAcWnM0q8nT+L EcL5zigxt/c/kMPBwStgK3FhGytIA5uArkTT212MILaIgJfEsqYzLCA2s4CzRPuk3YwQC3Ql dp95A2ZzCuhJtD76DnaEsECixPf1c8DqWQRUJS4t+soEYvMKCEr8mHwPao63xKQtS1ghbHmJ zWveMkMcyisxo/0pC4QtKbG65xY7xHwhiY6rnawQcWOJKf+WQtWbS1zcvpkJ5BcJgXPsEtd/ zmWHWCwg8W3yIRaQvyQEZCU2HWCGmXlwxQ2WCYxSs5CcNAvJSbOQnLSAkXkVo2hqQXJBcVJ6 kYlecWJucWleul5yfu4mRmCEnv73bMIOxnsHrA8xCnAwKvHwesz5HCLEmlhWXJl7iNEU6IqJ zFKiyfnANJBXEm9obGZkYWpiamxkbmmmJM77WupnsJBAemJJanZqakFqUXxRaU5q8SFGJg5O qQZGq/Cbp5QEH4e2/Ms+GRS3sPmiYFltnmzudKtjTBYSupN/Sm84WuH2tLlk052/bh2nGNu+ nXlnIG3t7Ov3+kOMeaml0mS1/Bq2Wc+lcq9PmZJeeWPJlAlt6veZmX5qrPVpU3naH5Z/aDpL YBrfv9Q2o20H1Oa0ZAkyVsiILWY7WGlzdtmKpQpKLMUZiYZazEXFiQCsq0MZywIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42I5/e+xoK6K25cQg+ltVhZH5nxltrjwtIfN 4vKuOWwWM87vY3Jg8Wj7WeZx/MZ2Jo/Pm+QCmKMaGG0yUhNTUosUUvOS81My89JtlbyD453j Tc0MDHUNLS3MlRTyEnNTbZVcfAJ03TJzgLYpKZQl5pQChQISi4uV9O0wTQgNcdO1gGmM0PUN CYLrMTJAAwlrGDMmXT/KVjCNo2L2+1XMDYxP2boYOTkkBEwkjqw+ywJhi0lcuLceKM7FISQw nVHi7fxZjBDOd0aJub3/gRwODl4BW4kL21hBGtgEdCWa3u5iBLFFBLwkljWdARvELOAs0T5p N1hcCKhm95k3YDangJ5E66Pv7CC2sECixPf1c8DqWQRUJS4t+soEYvMKCEr8mHwPao63xKQt S1ghbHmJzWveMkMcyisxo/0p1NGSEqt7brFDzBeS6LjayQoRN5aY8m8pVL25xMXtm5kmMIrM QrJiFpIVs5CsWMDIvIpRNLUguaA4KT3XSK84Mbe4NC9dLzk/dxMjOAE8k97BuKrB4hCjAAej Eg+vx5zPIUKsiWXFlbmHGCU4mJVEeF/LfwkR4k1JrKxKLcqPLyrNSS0+xGgK9OlEZinR5Hxg csoriTc0NjE3NTa1NLEwMbNUEudVsm8LERJITyxJzU5NLUgtgulj4uCUamA0fnJ50zEfo4ki 2wymeu3facFiYl1onXaK/YhF170lycKzvj2pXednkCJ47/+XrTc8eFUMekqyPQ6Knri1On4i 97WfkfMko5afDtkvo/Fm4ZzfsS7rVrVcrhW9IRw43TJH9ctahX0pBs+u3PCyfP1RYXLb9fDt 0tYGn+6kOn833KA9/6jxl6o9SizFGYmGWsxFxYkA5/B8yhYDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Friday, February 27, 2015 9:14 PM "Axel Lin" wrote: > Current code uses args->args[0] as array subscript of phy_drd->phys[]. > So the valid value range for args->args[0] is 0 ... EXYNOS5_DRDPHYS_NUM - > 1. > > Signed-off-by: Axel Lin Reviewed by: Vivek Gautam > --- > drivers/phy/phy-exynos5-usbdrd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/phy-exynos5-usbdrd.c > b/drivers/phy/phy-exynos5-usbdrd.c > index 0437401..e2a0be7 100644 > --- a/drivers/phy/phy-exynos5-usbdrd.c > +++ b/drivers/phy/phy-exynos5-usbdrd.c > @@ -531,7 +531,7 @@ static struct phy *exynos5_usbdrd_phy_xlate(struct > device *dev, > { > struct exynos5_usbdrd_phy *phy_drd = dev_get_drvdata(dev); > > - if (WARN_ON(args->args[0] > EXYNOS5_DRDPHYS_NUM)) > + if (WARN_ON(args->args[0] >= EXYNOS5_DRDPHYS_NUM)) > return ERR_PTR(-ENODEV); > > return phy_drd->phys[args->args[0]].phy; > -- > 1.9.1 > BRs Vivek