From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FE81EE49A4 for ; Mon, 11 Sep 2023 02:46:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232323AbjIKCqn (ORCPT ); Sun, 10 Sep 2023 22:46:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjIKCqn (ORCPT ); Sun, 10 Sep 2023 22:46:43 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA9C1B0; Sun, 10 Sep 2023 19:46:38 -0700 (PDT) Received: from kwepemm600007.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RkWGj60jyzNnHc; Mon, 11 Sep 2023 10:42:53 +0800 (CST) Received: from [10.69.136.139] (10.69.136.139) by kwepemm600007.china.huawei.com (7.193.23.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 11 Sep 2023 10:46:35 +0800 Message-ID: <110c02bf-3133-971c-750b-4a2d18bc9bf9@huawei.com> Date: Mon, 11 Sep 2023 10:46:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird CC: , , , , , Subject: Re: [PATCH V2 ethtool] hns3: add support dump registers for hns3 driver To: References: <20230829065656.2725081-1-shaojijie@huawei.com> From: Jijie Shao In-Reply-To: <20230829065656.2725081-1-shaojijie@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.69.136.139] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600007.china.huawei.com (7.193.23.208) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org on 2023/8/29 14:56, Jijie Shao wrote: > Add support pretty printer for the registers of hns3 driver. > This printer supports PF and VF, and is compatible with hns3 > drivers of earlier versions. > > Sample output: > > $ ethtool -d eth1 > [cmdq_regs] > comm_nic_csq_baseaddr_l : 0x48168000 > comm_nic_csq_baseaddr_h : 0x00000000 > comm_nic_csq_depth : 0x00000080 > comm_nic_csq_tail : 0x00000050 > comm_nic_csq_head : 0x00000050 > comm_nic_crq_baseaddr_l : 0x48170000 > comm_nic_crq_baseaddr_h : 0x00000000 > comm_nic_crq_depth : 0x00000080 > comm_nic_crq_tail : 0x00000000 > comm_nic_crq_head : 0x00000000 > comm_vector0_cmdq_src : 0x00000000 > comm_cmdq_intr_sts : 0x00000000 > comm_cmdq_intr_en : 0x00000002 > comm_cmdq_intr_gen : 0x00000000 > [common_regs] > misc_vector_base : 0x00000001 > pf_other_int : 0x00000040 > misc_reset_sts : 0x00000000 > misc_vector_int_sts : 0x00000000 > global_reset : 0x00000000 > fun_rst_ing : 0x00000000 > gro_en : 0x00000001 > ... > > Signed-off-by: Jijie Shao > --- > changeLog: > v2: remove #pragma suggested by Michal > v1: https://lore.kernel.org/all/20230818085611.2483909-1-shaojijie@huawei.com/ > --- Hi Michal: This patch has been uploaded for more than 10 days and has not been merged. Please review this patch. and if you have any problems, please inform me in time. Thanks！ Jijie Shao