From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D9362459D5 for ; Wed, 15 Jan 2025 13:00:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736946021; cv=none; b=dDamr+JkkhiCDdtZo97vDEjitmmXcJH84H3QZlFqhI1jukXrrZtjEZvmWEV2k6ecx1UrWRUFfdlQoAc5Riyjp6R65HI1DZDC2r5SSI0cug9kmNqDVi6dAq9WgstQKtC0KytxwNfiHsr/mE2Lc7KUfiRoud2TbUAC7dr0yAF/fJI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736946021; c=relaxed/simple; bh=kzlfC1+cC7sNCeZW1PWc+gUgaGnEtxzXhYzYXBStw9w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MAYMb6+VXfMulVz4FMLj366Mb3GTZefe/J2OCkx23bWITn9TbjHb3CU4Ob+FepV/BBwJMJ7sMnRlxRl2KSdS1PmfoWjtDouDwXVsT/K7mzOxjF9Ayvr9TdIIuFaqXnIt2rPtb2uYVb7nBsnvAKKA3lhyjqiBaD1kmpUs4KtCEXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KgRGiLgm; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KgRGiLgm" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3862e2c9bb5so289982f8f.0 for ; Wed, 15 Jan 2025 05:00:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736946017; x=1737550817; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=6SLQpzwmxyFpdnS0Qhwyf7oPOCOoHDHPhYDyk3jPItc=; b=KgRGiLgm7z9SGfNJJfW5TIKTHlTarTNB1JLOzkn78+2CbLy8Oa/My1d2LsWinDHTu6 1WDg6DQeKydTbZqfQLDNfA+jhPazMpradUulnNSdHg8WsscQgsfdEaFdvK8nTHQG6IZi fxP0U32hznRq0bnA0HLCkAQv/6NnV0VXjg+OHgTMo1VNAl80DAFrggZDgo7sSEQWtzb1 LUff8pg4Hl+8MSn80cZQCP7nvGUUFpqhAvvyVQtEKqBlEegvyTMkJAiFTW8RLvA8CSTT bRK2B0Q+61aVFxEAPhottMOL3GaZXExyrGsWELvpVPpb7Eks/dhsQgAxkimwEE5B98sJ jWUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736946017; x=1737550817; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6SLQpzwmxyFpdnS0Qhwyf7oPOCOoHDHPhYDyk3jPItc=; b=cERZjOQEGB/13odsliUS2n/pP6IieuWrY46j+EeSgAj/A1XmVx6uvZAX/VOUSYCf6S DlO/sBz7jaxOKDnMwaqGO1j5pmtkNObIGXSde6U5kg0Rp71ee2WdzHG8rC+8n1bFcsph 91OlTSEoUv7k7rEqAzM9f3ClaHsiOcK20bJNj/sDGXqiupQCw7u+a3edNt+q8rKXIhMf 79uPthqzMIDUvYBRyVXBWGR9EEfOJ6E4Bzb0LRTFsmbKTiuMgHwLjxro+E0qDgpLl8EF tejm/T/R/z3EDO0jEk1oJrFcNBuBT+cQs8zNKKa0M3sT6v4owB6SZSpp3Ofh//F+OcSz 3h5Q== X-Forwarded-Encrypted: i=1; AJvYcCUrgOwB6fnz4+Kj9pdkM2xVN2bOLydQk3Ar7K+nqm1+OHX9BIFPN590sbkQ19ndxWh/zvN/Kqyg/s+WoSo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5O0LtEn4iS0fHOLo8pw8FGlj4E6G69Lj/UBHTLWWsR+qxpuB3 7nQVUUSAoje6OAHlctbl3w9BlzUysDJzI/Q+RUOMD8crWUdLOXXC1vjPWHNIAZg= X-Gm-Gg: ASbGncvvTnO2D/6wC9Hd3Slhn9ansoOvCHtA0nnODfPNaMOaI6qrXgerGfRzQ9DAYbJ atkHoTRY50lYbhoSao6F5g/a2UaOEBH7QPPIE74FOMX6YdixR89XJe0oZCtzWZs3lHTuBYf0PBE 3ZLBL5g2DfTjWg+0J7U8dCItY1cn5wLYmDOTPFLAn6CEpScnOk+bobOJ9h0BXQvEWXe+QWicO9I ww7KMwk4F0DF0CI9LAx16GEvOi1sUiwD1yeWXOfsKW64qP7iU0LAZvD576sfgEv+xT/yy00Nplm X-Google-Smtp-Source: AGHT+IHGXsmacyZvTLB1+zaeUtblvRQoTtrVI7XUlTrmBMIq4H1j0GTh8m9KEp0KmLuowI3RDVUF4g== X-Received: by 2002:a5d:648f:0:b0:385:fd31:ca24 with SMTP id ffacd0b85a97d-38a873105d7mr10755610f8f.12.1736946016850; Wed, 15 Jan 2025 05:00:16 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.165]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e38d008sm18004245f8f.59.2025.01.15.05.00.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jan 2025 05:00:16 -0800 (PST) Message-ID: <110c9b58-9ac1-4a24-84da-4dfc722f1ea4@linaro.org> Date: Wed, 15 Jan 2025 14:00:14 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gpio: Use str_enable_disable-like helpers To: Linus Walleij Cc: Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Bartosz Golaszewski , Andy Shevchenko , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com References: <20250114191438.857656-1-krzysztof.kozlowski@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 15/01/2025 12:51, Linus Walleij wrote: > On Tue, Jan 14, 2025 at 8:14 PM Krzysztof Kozlowski > wrote: > >> Replace ternary (condition ? "enable" : "disable") syntax with helpers >> from string_choices.h because: >> 1. Simple function call with one argument is easier to read. Ternary >> operator has three arguments and with wrapping might lead to quite >> long code. >> 2. Is slightly shorter thus also easier to read. >> 3. It brings uniformity in the text - same string. >> 4. Allows deduping by the linker, which results in a smaller binary >> file. >> >> Reviewed-by: Florian Fainelli >> Signed-off-by: Krzysztof Kozlowski > > For a while I was critical about the string helpers but since both Andy > and Krzysztof like them, I will consider myself convinced and start to > like them instead. It is pretty subjective, so I also find reasonable not to accept them to your subsystem. To me they bring more benefits in complicated cases like: (data_in ^ in_pol) & msk ? "hi" : "lo", or from pinctr (note the line break): seq_puts(s, pin->output_value ? "high" : "low"); Anyway, thanks for review! Best regards, Krzysztof