From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751323AbdBJGj5 (ORCPT ); Fri, 10 Feb 2017 01:39:57 -0500 Received: from mail-by2nam01on0071.outbound.protection.outlook.com ([104.47.34.71]:65248 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750989AbdBJGjz (ORCPT ); Fri, 10 Feb 2017 01:39:55 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH] i2c: designware: Fix regression when dynamic TAR update is disabled To: "De Marchi, Lucas" , "mika.westerberg@linux.intel.com" , "andriy.shevchenko@linux.intel.com" , "jarkko.nikula@linux.intel.com" , "Nehal-Bakulchandra.Shah@amd.com" References: <1486669851-25632-1-git-send-email-Nehal-Bakulchandra.Shah@amd.com> <1486670858.2133.436.camel@linux.intel.com> <1486676048.14478.4.camel@intel.com> CC: "wsa@the-dreams.de" , "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "Shyam-sundar.S-k@amd.com" From: Suravee Suthikulpanit Message-ID: <110f9081-ddba-82c2-6ba3-f92bc36d0bc3@amd.com> Date: Fri, 10 Feb 2017 13:38:37 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1486676048.14478.4.camel@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [114.109.128.54] X-ClientProxiedBy: HK2PR0201CA0020.apcprd02.prod.outlook.com (10.162.206.30) To DM5PR12MB1451.namprd12.prod.outlook.com (10.172.38.140) X-MS-Office365-Filtering-Correlation-Id: 07dca0d9-cbf3-47ab-85d5-08d4517f7ea5 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:DM5PR12MB1451; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1451;3:CF2/kKGEIxYlfq5kDBRl2VHi2XYrY/Qo6trMPV+WTQxTLDSuMhMESRJJs9CXuUsLvD/r3MYkJ7rd3WKxNq1JS9ZzyeiDEs9twW9K2fJ8MAcoH9HPxtEQ2PhvFW9iCzHFizXOkqQLcRYbojI8L1nrfKsHE2s0uwEg8wCAr3g/P6Q4/FPVNQwhdnftLvwPXlKuIPxUQplX5DXcVC+rKjdpCY4u2LjDuqHTNSrY5TWsxuQxw1eQsuphzLTgeMF1GHJwOl3lNAOxx5rbZwZvqTM8LfEOkOh6fCiM8Dc+FLGyDLg=;25:f3WHfp1wxtzShCiEfKjMw45v7kbXLm4Stj5buC3KIpdQ90RoYgATwFPGuOdpSMGMJSM+aH4a8YbpMZjCsblB3I8aS+8tIB9otbLCs2RqQwD2M0zD89p65dsutBZ19N3p2wa5a0S/uYs6Et8zVuKTLJ0LBC5RADNfU5Eh4mK9h1NGFx/TBwZkVqWPkcVmVNcI+eRNvlbcHL9gp44sJFEoryMcqvR28oqyn7HHQzv5Hl4HKwEZ44fUySyNxc42BVJaHjG6jwSyHRiSaSRwOelDl2EajDhASb0L7eBPUzmWPC98ZK+XQevYb7I9HGgdxn4D+VKll49TivaerzXVYfEtbgCLa3wbj/HFzeaQysDaRVYffv2hbx7xGha+BBirSf2z3495Xuo5jSOAhJ+vd2yLpBlbd/oTDmhqpe7qc2BXuHl6zyvYWjpQGyQEP0kNTqYPPSbPjCdZ+BgO/BAODxSfCQ== X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1451;31:VtuOZqaL/xQzCOUFRnUmWTyqCbFiVPUMoGDpm5iFhUiBVB+7o/+1r97rNxzzPhqfMUaAMnnFkd6fI/1MmpKG4JZDUIXwn8prbpIS+PAZ1xZF4NSf0GQjYwpvArq4rQWvJzrzScdNAyCy5NfXH+2iAnWJN7KyzNSU3QjnE2n70TfLSGy1YOgVChqWi4u5JwzWzIA1dBWWFcuDHmF3divRxYFbYqD38H6zLvUgtAacJmY=;20:qFn79SijS4Trqo0jNf+wxQdnYv9QPDA+mEux0eyrZ+4gnP2vwA5iKkZJnAHgMlhXvTYl1ud+N6HbmxQ2Pvmo7CMIPpKWKG3c1+JMo7mVx3u8HTO/gQX6K6wV0xxtuxPVlGEKvXVBdlfaotrtXQOS1G9tPmFlWRVES3tHztSItEHnfCZEQWq/BESNQvnF22D4uSoYzReubfeV81jPx2vaixBh99CBwTv5APKWM33pqet7b286AtiV0c7RGORUyuUeE5bC/xXPKh4igKlO+6+LK246i42L373wpWoVZPCiwNgq9uTGBUXpRhzLMu0d0HxbwIlJ4kd+e7TLor31KEWEH3cCjEZ6uVSc7rrbVNooEDcR4t8FPH5DWH9+PGSBRErpVOgYJy5oibb6AxvOCiA1ZO5CYMQbTts8bICtVjVWvKa0GIY2rQ10U0pdWjHqvv/dO96xOPpvu7Cetu/V9GPjHdKa5KTx8LVl9z1xmf9w6k+NsUGW+WpqIBNnBIxjNGKF X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123558025)(20161123564025)(20161123555025)(20161123560025)(20161123562025)(6072148);SRVR:DM5PR12MB1451;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1451; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1451;4:5krAB7/wvpMtPOohN3oIbPiZH0c1jJ1fQH32TmLxcGdrho28PghJ2Torvfo8XqM+txtoT+TM5z/0lULguVZEInTu7p8HHNz+6B1Kpnc/6Zf5gWqPQFWK8KQGIynuwmqMZ+Rk2kNz8fUIvdzQj1jmMbN2yiREoOfoA15YNmcqIVydovC0SQfN2iziYlsu/Iov9wt0pz/GMvleR04tlXFgCX3TmqSDTXUBebsMbFNU/4/sUb3KrgLUvA9BL4dKXRYT5pfWtjUnRkDMoxnAf4DnMdHbc1ZSgGbUuq95V9ZBzrfjgHc/gdakEI/3WcXCYBqUt6TV6dDoE2iJwTnEbaF7h1fbvCkP8eNdLtkjay1KUae4B00DoBTj6O89CaBCvCbipnE32BkD8WrHSGxaScZCqStPVneDHBAj+hvUwf3V0gcbTbCE5UHfcIKfkE/EdJ8hFPhQjt25ph9Shf/EK+w/tc3SPzexdI5LHCzaqLq6munQKuPzGmCKhYpBIaVzyWfopYxR/Md5+9qNwVualKSK2Nz+x5jMeZbxN86X1LRZ3pky8+Xvc3dv8pMVNmWF1oqW/GxuRVXuuVGmVG6lMd2Jv0fqm4MwvyOSB/4rcFcRlefw7MxG7APCCv66uPsFrqum X-Forefront-PRVS: 0214EB3F68 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39850400002)(39410400002)(39840400002)(39450400003)(39860400002)(377424004)(24454002)(189002)(51914003)(199003)(92566002)(575784001)(31696002)(25786008)(86362001)(2201001)(38730400002)(6246003)(53546003)(50466002)(305945005)(64126003)(229853002)(5660300001)(6636002)(2950100002)(6666003)(7736002)(50986999)(54356999)(23676002)(15650500001)(76176999)(65826007)(101416001)(53936002)(4326007)(4001350100001)(6116002)(97736004)(2501003)(106356001)(42186005)(36756003)(81166006)(81156014)(31686004)(68736007)(54906002)(8676002)(83506001)(3846002)(105586002)(230700001)(189998001)(66066001)(6486002)(65956001)(2906002)(65806001)(33646002)(6512007)(6506006)(47776003);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1451;H:Suravees-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxNDUxOzIzOk5ndDFXN0lKdVh3LzZSRXlrRnYzMXJJVVRy?= =?utf-8?B?Y1pVMG5xTEo4clR4WFVFWDZPYmdrbllzRkN0S012czUvVi9zRy9RVFhuekIx?= =?utf-8?B?c2tiNk5kSHgyQk84YTRQZElvU1FvNk9PeEo4MXBuUFBUaXRPS1ZTS0cxYzZr?= =?utf-8?B?ejFSRVRCNFl4OXdEZTNmZUtid1VkanIzaG9nQTNkbmNrRnE5Q3ZIK0RuclZT?= =?utf-8?B?U1doek1ML1IxcHE5QlAvU3NzdTI5MTdpVFdxR0NKUEt2QjA4ZTUyRk1mdWcr?= =?utf-8?B?aVVLSkxabStaczViYzhRRlNzUGxJVUl3bUx0NmFVTmtVK2IvQTh1cHdYWEtk?= =?utf-8?B?eDM3dThNazFiM21zOGROa2U5WnBJYlhVbm9OVDFFNXAwS0ROVUlXUGo0VHY2?= =?utf-8?B?NzFxODNnRnJaR28vM0cvMU50N3duUlNMSS9NRUNVZmNRNVRXVWdsQ3dxWmRk?= =?utf-8?B?MnUxa3l6SDkvZWorVkcra2k3YlhZbmhMM296aEI0RmdBaTN5UzBnYUF3MkVW?= =?utf-8?B?ckowa0k0V3hhV0ljaVBKYW9aNG01bHdCWkV5Ui9mWE44NnVrUFJtM3lIVXRn?= =?utf-8?B?UlZNa05MU3g5OHZ2K2hFOWl6cmEvUWtNV2F2c0srdE9Wd3JnOU9ITlBCSVJx?= =?utf-8?B?UUN4eVhrdDlkZjdYZEkyNklsUnpGNGwzem55SXlIN25pYkZTNmM5czRCdnpq?= =?utf-8?B?NURreDlPcVNaZHA4NGoyMkh4QWFPUXRmR2ZPSEtZOHg5L0U0czJGMWh6TkZC?= =?utf-8?B?eFBPcDMrbklIUGlXSEErMWwxRHNjc2dkb1pSWVBaKytqazdSMXRTMTBWVVlQ?= =?utf-8?B?YmVUSytXaTNjeUZFOU9Idm1pRDFOSTJDUDhYWnYvbjJGb2RpVXcrU3dFUGVQ?= =?utf-8?B?NmhWUEpjZkpMd2laM0N1OW1adi9mZXpkUVhqd0o1Qkt4ejZ6TWI5S1JQNXZU?= =?utf-8?B?Rk0wcitBS0tEQWs3Q25wR3drMmFmQmVRR1RpMS9KUE93K0F1Q016cjZIWkdp?= =?utf-8?B?MDVPc2lXNTRPOTdtekhsQ1VtbWZOR0pzdjdHTkpzZCttUVdZdHI1dDhoNjVJ?= =?utf-8?B?WEQrMWJDSkxuU29iL3ZtRjZnbEFBblpDZGxUNnRBeXJTUW1mV2ZtcEhrZ05M?= =?utf-8?B?UnJKZllEUWtpekgxSE9SRzl2aFhGSHVkYlcvTGFOMFpkZ2MzQnA1QWVsNHV0?= =?utf-8?B?SGpOQlhQVm1SM1pkOWhmbG9qMVFGb1NrbldwN0M3aTF1VWFnQXFyMHhVYWxu?= =?utf-8?B?WmoxNC9MVXJNRW8vS3pHUzZpQmZUY1BVWkxGbXRuSFFEcGFuVXdQS1M2K1pV?= =?utf-8?B?SWgweS9MOHRMS2YySlk1Y3lxRGhoaW5kZjd2ai9oZThtaStrTndKV1QyT3JD?= =?utf-8?B?a0FRcXNHWW4xMnBYcHFubnlMUm03MHJQbjJKUjBieG9lbkp4cmI0ZmpmeGNN?= =?utf-8?B?eU1PMzArSXVPVE9CZURNSTNhK3F5ak5oME5XRlptNjNnVGlyVWJRR3dkMjlU?= =?utf-8?B?Q0laOXZPNUxsd2lqbTNZT1RkWTcrUFFMTlp2UHhPVHB3V2N4U00rVy9qUGpV?= =?utf-8?B?blVmdHZwbUozM0kxTGg2Z3JPLzhFOE9kSWYwYzZQZytRMGsxWWxUM1BCMEVy?= =?utf-8?B?ZUVzZkpQZmVLbnN4VklMYSs2N1poeGJVaUZDS0gxWEpDT2tiall3SzNDcTBi?= =?utf-8?B?Uy9lTlg4cFVMSmRPRVhPZHRRdEZidU1Qa0pKTG9SajVGVFgzeDRqWVkzcDA3?= =?utf-8?B?V3Jza0VpMnlHa2c2MGNNdUgvcWJPU3pUczFnUVJhbUFvRjZXVUhFbFJzdG1Y?= =?utf-8?B?dmJ4bG5wZFVzRmVKTmxGdUZ1RGMyTXpSaTl6cmpxNXlBdVRvYlhuWXRwZmVs?= =?utf-8?B?YklOTTdYb1dTVk50ZlBKRzBpZUN1SnBnY21wdENmYjRMT1VvSDRYSWJTVUd6?= =?utf-8?B?OGdPL3kzNXJUcXdDYmNEZWJvQmp6UERRNVBMSzczeHdwMDVXWHJyenV3YXpr?= =?utf-8?B?TEtRdUI4VDNzS0Jrb2NTSTdpSnd1VTRVb0ZMbzZUcVZDTElWbGQ3Qkd2cUJh?= =?utf-8?B?ditheGxRYnZQRVAwdFpjSTF6QTdmRHU0L08zT0JMTmZSR28wYTNxZmN4bVNP?= =?utf-8?Q?1gufrtvfDOOfHiNPqim/WH+aVCrGs1GaFYMmn3zUtM3O?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1451;6:+av5vAW/V/J8BzDdNZvIfZaq1iwYmRyRUfguI4Kexjp46vPnHaSNDWG/4/P0ACDLskeSEfehIhqX77HelLjnFF+4/MWu9HHwaxc3AAUqAV/rQm0Ab/gWYC6th0bJzXRlDvqPAWqnmt7AXSgKj+xiGgQVwKLzMsXfqyu1ycZk1NsFlWtMBI5n+fCZv4XlY8OfQvSgyOARNPd2IKUZipVRut/iTRDC5mi2+PMi9fiS5sUdovVzQ9pGg56l9js7iSYwwmS2Dok31d7jNvO3efuBkQejwSUCKVSgYCSCL1qOKko7U0Dex6O6Fi6/fqCdEO/eY483RR2S3D+7QYKVG6WN7rhL1zk8OfXQGQMn62EEbgOnrLW8sIj1bcPd8UV21PvT0dZ2ntlqzRFAuj32bVR5FWc0G9wEXkIP3CBq+aquWIc=;5:RHiwdJGB6loX0NDKPh9ijfW74O2rPMNnd3QYi/+Dg1wd0/vFtgOx9gJAidM2Kvd3V47eCQE1jkBmX83EoeSRzIxLl3iJSLkJN7ruQhrSauEVoLA803sfdSt5hefheQmxsmaU2/R61AW4e9M9Me4vEw==;24:94j+hjanEi6Yy4NGcB7BTtqLKvmnnSHT2Fcuc9OmG9J90C7Wlgj+QqxfDtDXyvs3zm1yI9pg3D5+6aGSCYidDGT5o36KpUNsIB/n7aJeto8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1451;7:FzrY5T5E5Y6gbCtoJveX6fx581Vne93zFy8JMzJ1ygTXjmvLeMIjgOmXqpPimH9MXhgM2pWyTYmF4dNQs99YXpJC81SvOyUHXrNyqxDrEPtNSz3hV3ML8n8KQ4PiF73z+2axLqhWaenfugpO/+cvUGSaZUJQVRbJ/CtHt16RlvlSMKRRhnAPaOZHlGR4TIKjgsQGkJTyWLqeBnPTMhYb0dvAk8WTmbao/hR5qC2WCzm/qLfOz11ZImBaiZv/rLM357YCx7C+MT8qjHPSy+lvWqeRxeb7cBVqybSz7LWmr5RHFRCOr0SWbUUZHodNxDhs7cBbQu9Dhk0deGqPAEOpseQsMhMfPc66+jNRagIBdYrxOxZNXNwHWNJhP3Ww0KFaB+E1TwXtj6C183en2YZRteYAsGv8cZQbPy2WKRgfQQ7iXnm1m+3uz+y6RJYl4L+YvGDKMFJvNlaR7NDIcDdco1YRjUnA5kRyxuxzHzNaI1ydtJhMDv+/d0ABi2ozWkN1ln0kMx8t6Xjf3sYh6fozlA==;20:AcO8SXcH3QEotBU/7K6QtaEciQrKNhVJ8PRt8L3bu8x5bXJ2avmW7CTx378Qytv4re2S34ZqkB++dkAOkP1fQ/uxIKZ2zu3pba9C4CterWrTegEcyA75ZvHoK8UpOFTTlshIqMM8RPxwNlWpce3tEHKYCZ2aW6OcMvZc3QdNpCdB10KFMO0nr41Q5a4VdxUoy68oSzIfNWMJAP+tdLb4WbdahxALqgQ9WIjccxV2tMQxu4LtbZSBlmMbm3qS1uIE X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2017 06:38:56.5862 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1451 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/10/17 04:34, De Marchi, Lucas wrote: > On Thu, 2017-02-09 at 22:07 +0200, Andy Shevchenko wrote: >> On Fri, 2017-02-10 at 01:20 +0530, Shah Nehal-Bakulchandra wrote: >>> The following commit causes a regression when dynamic TAR update is >>> disabled: >>> >>> commit 63d0f0a6952a1a02bc4f116b7da7c7887e46efa3 ("i2c: >>> designware: >>> detect when dynamic tar update is possible") >> >> Please, leave just 12 characters, it still enough. >> >>> In such case, the DW_IC_CON_10BITADDR_MASTER is R/W, and is changed >>> by the logic that's trying to detect dynamic TAR update.The original >>> value of DW_IC_CON_10BITADDR_MASTER bit should be restored. > > You are right, thanks for the fix. This may also explains why > 0317e6c (i2c: designware: do not disable adapter after transfer) caused problems > and ended up being reverted. Could you try that on your hardware? After looking at the patch (i2c: designware: do not disable adapter after transfer), we see that it modifies the i2c_dw_xfer_init(). However, this function is never called on our platform. So, this patch would not have any effects. At this points, my understanding is there are probably two options here: 1) Keep the commit 63d0f0a6952a (i2c: designware: detect when dynamic tar update is possible) and apply V2 of this patch in 4.10. We might need to back-port the change to v4.9 stable as well. 2) Revert the 63d0f0a6952a (i2c: designware: detect when dynamic tar update is possible) in 4.10, and also in v4.9 stable as well. Thanks, Suravee > The dynamic tar update detection was only done as preparation work to allow not > disabling the adapter, which is reverted. We may also just revert this commit > instead of fixing the logic. > > > thanks > Lucas De Marchi >