From: Arjan van de Ven <arjan@infradead.org>
To: "Bagalkote, Sreenivas" <sreenib@lsil.com>
Cc: "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>,
"'James Bottomley'" <James.Bottomley@SteelEye.com>,
"'Matt_Domsch@Dell.com'" <Matt_Domsch@Dell.com>,
Andrew Morton <akpm@osdl.org>,
"'Christoph Hellwig'" <hch@infradead.org>
Subject: RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers
Date: Wed, 09 Mar 2005 18:16:19 +0100 [thread overview]
Message-ID: <1110388579.6280.134.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <0E3FA95632D6D047BA649F95DAB60E570230CC1E@exa-atlanta>
On Wed, 2005-03-09 at 11:01 -0500, Bagalkote, Sreenivas wrote:
> >
> >> . And since this is compile time
> >> system-wide property, I kept it as driver global.
> >
> >that step I don't understand... why is it a global *VARIABLE* if it's
> >compile time system-wide property...
> >
>
> I see your point! Are you saying I should use if(sizeof(dma_addr_t)==8)
> instead of the shortcut if(is_dma64)?
yep
well you can use a preprocessor define of something to make it slightly
more readable (eg shortcut) if you want, but that's what I mean yeah..
gcc will optimize the entire unused code away this way, including the
actual conditional jump, so for performance and bloat-ness point of view
it's nice.... and of course generic design beauty ;)
next prev parent reply other threads:[~2005-03-09 17:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-09 16:01 Bagalkote, Sreenivas
2005-03-09 17:16 ` Arjan van de Ven [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-03-09 23:56 Bagalkote, Sreenivas
2005-03-09 22:47 Bagalkote, Sreenivas
2005-03-09 22:59 ` 'Christoph Hellwig'
[not found] <fa.ia0cbem.oiit9q@ifi.uio.no>
2005-03-09 17:59 ` Bodo Eggert
2005-03-09 17:44 Bagalkote, Sreenivas
2005-03-09 18:19 ` Arjan van de Ven
2005-03-09 14:43 Bagalkote, Sreenivas
2005-03-09 15:52 ` Arjan van de Ven
2005-03-09 22:03 ` 'Christoph Hellwig'
2005-03-08 23:08 Bagalkote, Sreenivas
2005-03-09 8:06 ` Arjan van de Ven
2005-03-08 22:58 Bagalkote, Sreenivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110388579.6280.134.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=Matt_Domsch@Dell.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sreenib@lsil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®