From: Dave Dillow <dave@thedillows.org>
To: Park Lee <parklee_sel@yahoo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Ipsec] Issue on input process of Linux native IPsec
Date: Thu, 10 Mar 2005 11:18:52 -0500 [thread overview]
Message-ID: <1110471532.5050.14.camel@dillow.idleaire.com> (raw)
In-Reply-To: <20050310103724.11220.qmail@web51506.mail.yahoo.com>
On Thu, 2005-03-10 at 02:37 -0800, Park Lee wrote:
> On Fri, 24 Dec 2004 at 16:15, David Dillow wrote:
> > xfrm_lookup() is only called for outgoing packets,
> > not for received packets. I don't think ping
> > replies (ICMP echo replies) will ever have a non-
> > NULL sk, as they are not associated with a socket.
> Then, Why did you say that ping replies (ICMP echo
> replies) were not associated with a socket?
Because your crashes where caused by blindly assuming the sk would never
be NULL in xfrm_lookup(), and it clearly was. The simple debugging
printk() I suggested you insert with your code would have shown you that
that was the reason for your crashes.
And if I was feeling nice that day, which is possible, since it was
Christmas Eve, I may have even put the printk() in myself and tested.
> Is there any difference between the special purpose
> socket and the socket you mentioned above?
I have no idea. You have the code, and probably as much understanding of
the networking stack as I do. I suggest you use find and grep to track
down the what you are interested in, and how xfrm_lookup() is called in
various situations. Take good notes, especially about avenues of
exploration that come time mind as you chase one code path. It's not
very hard, it's how I learned.
--
Dave Dillow <dave@thedillows.org>
next prev parent reply other threads:[~2005-03-10 16:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-10 10:37 Park Lee
2005-03-10 16:18 ` Dave Dillow [this message]
[not found] <41ae448404122203477e71bb83@mail.gmail.com>
2004-12-23 6:29 ` Park Lee
2004-12-24 6:23 ` David Dillow
2004-12-24 19:23 ` Park Lee
2004-12-24 21:15 ` David Dillow
2004-12-25 17:47 ` Park Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110471532.5050.14.camel@dillow.idleaire.com \
--to=dave@thedillows.org \
--cc=linux-kernel@vger.kernel.org \
--cc=parklee_sel@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®