From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ppc64: Add IDE-pmac support for new "Shasta" chipset
Date: Fri, 11 Mar 2005 20:36:32 +1100 [thread overview]
Message-ID: <1110533792.5751.69.camel@gaston> (raw)
In-Reply-To: <20050310231700.5486ccd4.akpm@osdl.org>
On Thu, 2005-03-10 at 23:17 -0800, Andrew Morton wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > The iMac G5 and new single CPU PowerMac G5 come with a new revision of
> > the K2 ASIC called Shasta. The PATA cell in there now does 133Mhz. This
> > patch adds support for it. It also adds some power management bits to
> > the old 100MHz cell that was in Intrepid based ppc32 machines.
>
> Compile fix:
>
> --- 25/drivers/ide/ppc/pmac.c~ppc64-add-ide-pmac-support-for-new-shasta-chipset-fix 2005-03-11 07:12:01.000000000 -0700
> +++ 25-akpm/drivers/ide/ppc/pmac.c 2005-03-11 07:12:20.000000000 -0700
> @@ -1301,7 +1301,7 @@ pmac_ide_setup_device(pmac_ide_hwif_t *p
> */
> if (device_is_compatible(np, "K2-UATA") ||
> device_is_compatible(np, "shasta-ata"))
> - pmid->cable_80 = 1;
> + pmif->cable_80 = 1;
>
> /* On Kauai-type controllers, we make sure the FCR is correct */
> if (pmif->kauai_fcr)
> _
>
> (Wonders how well tested this was).
It was tested, sorry about the mistake, I fixed that compile error and
forgot to run "quilt ref" :)
My bad ...
I'll double check that the other patches are indeed the right versions
tomorrow...
Ben.
prev parent reply other threads:[~2005-03-11 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-11 6:45 Benjamin Herrenschmidt
2005-03-11 7:17 ` Andrew Morton
2005-03-11 9:36 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110533792.5751.69.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®