From: Arjan van de Ven <arjan@infradead.org>
To: Roland Dreier <roland@topspin.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: inappropriate use of in_atomic()
Date: Fri, 11 Mar 2005 13:38:39 +0100 [thread overview]
Message-ID: <1110544720.9917.3.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <52k6oe9412.fsf@topspin.com>
On Thu, 2005-03-10 at 20:53 -0800, Roland Dreier wrote:
> > Consequently the use of in_atomic() in the below files is probably
> > deadlocky if CONFIG_PREEMPT=n:
> ...
> > drivers/infiniband/core/mad.c
>
> Thanks for pointing this out. I'll get you a patch in the next day or
> two. As you can probably tell, the code is just trying to decide
> whether to use GFP_ATOMIC or GFP_KERNEL to allocate a couple of
> things, depending on what context we're being called from. So at
> worst we can just change to GFP_ATOMIC unconditionally.
normally you are supposed to know what context your allocating function
is called in... if you don't know that often is a sign of a misdesign...
next prev parent reply other threads:[~2005-03-11 12:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-11 4:40 Andrew Morton
2005-03-11 4:53 ` Roland Dreier
2005-03-11 12:38 ` Arjan van de Ven [this message]
2005-03-11 6:25 ` Stephen Rothwell
2005-03-11 9:11 ` [ACPI] " Jan Kasprzak
2005-03-11 9:46 ` Andrew Morton
2005-03-11 12:26 ` [Linux-fbdev-devel] " Benjamin Herrenschmidt
2005-03-12 0:13 ` Andrew Morton
2005-03-12 0:22 ` Benjamin Herrenschmidt
2005-05-31 0:20 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110544720.9917.3.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@topspin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®