mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] break_lock forever broken
Date: Mon, 14 Mar 2005 16:01:42 +1100	[thread overview]
Message-ID: <1110776502.5131.33.camel@npiggin-nld.site> (raw)
In-Reply-To: <Pine.LNX.4.61.0503122311160.13909@goblin.wat.veritas.com>

On Sat, 2005-03-12 at 23:20 +0000, Hugh Dickins wrote:

> Since cond_resched_lock's spin_lock clears break_lock, no need to clear it
> itself; and use need_lockbreak there too, preferring optimizer to #ifdefs.
> 

FWIW, this patch solves the problems I had in mind (and so should
solve our copy_page_range livelock I hope). I was sort of inclined
to clear break_lock at lock time too.

As Arjan points out, an unconditional set is probably the way to go
if we've already dirtied the cacheline.

> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> 

Thanks for doing the patch Hugh.




  parent reply	other threads:[~2005-03-14  5:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-11 18:51 Hugh Dickins
2005-03-12  4:34 ` Andrew Morton
2005-03-12 23:20   ` Hugh Dickins
2005-03-13  8:23     ` Arjan van de Ven
2005-03-13  9:35       ` Hugh Dickins
2005-03-13 13:52         ` Arjan van de Ven
2005-03-14  5:01     ` Nick Piggin [this message]
2005-03-14  7:02     ` Ingo Molnar
2005-03-14  8:03       ` Nick Piggin
2005-03-14  8:14         ` Ingo Molnar
2005-03-14  8:24           ` Nick Piggin
2005-03-14  8:34             ` Arjan van de Ven
2005-03-14  8:43               ` Nick Piggin
2005-03-14 10:46               ` Ingo Molnar
2005-03-14 11:01                 ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1110776502.5131.33.camel@npiggin-nld.site \
    --to=nickpiggin@yahoo.com.au \
    --cc=akpm@osdl.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®