From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Borislav Petkov <petkov@uni-muenster.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.11-mm3: BUG: atomic counter underflow at: rpcauth_destroy
Date: Tue, 15 Mar 2005 18:52:58 -0500 [thread overview]
Message-ID: <1110930779.22062.13.camel@lade.trondhjem.org> (raw)
In-Reply-To: <200503152321.52799.petkov@uni-muenster.de>
ty den 15.03.2005 Klokka 23:21 (+0100) skreiv Borislav Petkov:
> After some rookie debugging I think I've found the evildoer:
>
> rpcauth_create used to have a line that inits rpc_auth->au_count to one
> atomically. This line is now missing so when you release the rpc
> authentication handle, the au_count underflows. Here's a fix:
>
> Signed-off-by: Borislav Petkov <petkov@uni-muenster.de>
>
> --- net/sunrpc/auth.c.orig 2005-03-15 22:34:58.000000000 +0100
> +++ net/sunrpc/auth.c 2005-03-15 22:36:23.000000000 +0100
> @@ -70,6 +70,7 @@ rpcauth_create(rpc_authflavor_t pseudofl
> auth = ops->create(clnt, pseudoflavor);
> if (!auth)
> return NULL;
> + atomic_set(&auth->au_count, 1);
> if (clnt->cl_auth)
> rpcauth_destroy(clnt->cl_auth);
> clnt->cl_auth = auth;
The correct fix for this has already been committed to Linus' bitkeeper
repository. See
http://linux.bkbits.net:8080/linux-2.6/cset@42332338Oz6uYqdnuwFBM5JHXlBCCQ?nav=index.html|ChangeSet@-4d
Cheers,
Trond
--
Trond Myklebust <trond.myklebust@fys.uio.no>
next prev parent reply other threads:[~2005-03-15 23:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 22:21 Borislav Petkov
2005-03-15 23:52 ` Trond Myklebust [this message]
2005-03-16 6:23 ` Borislav Petkov
2005-03-16 7:02 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2005-03-15 12:32 Martin Zwickel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110930779.22062.13.camel@lade.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=linux-kernel@vger.kernel.org \
--cc=petkov@uni-muenster.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®