From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Christoph Lameter <christoph@lameter.com>
Cc: Andrew Morton <akpm@osdl.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Replace zone padding with a definition in cache.h
Date: Wed, 16 Mar 2005 15:24:59 +1100 [thread overview]
Message-ID: <1110947099.24808.3.camel@npiggin-nld.site> (raw)
In-Reply-To: <Pine.LNX.4.58.0503152010190.5134@server.graphe.net>
On Tue, 2005-03-15 at 20:12 -0800, Christoph Lameter wrote:
> This patch removes the zone padding hack and establishes definitions
> in include/linux/cache.h to define the padding within struct zone.
>
> Signed-off-by: Christoph Lameter <christoph@lameter.com>
> Signed-off-by: Shai Fultheim <Shai@Scalex86.org>
>
> Index: linux-2.6.11/include/linux/cache.h
> ===================================================================
> --- linux-2.6.11.orig/include/linux/cache.h 2005-03-08 18:40:15.000000000 -0800
> +++ linux-2.6.11/include/linux/cache.h 2005-03-14 10:33:45.247701040 -0800
> @@ -48,4 +48,12 @@
> #endif
> #endif
>
> +#ifndef ____cacheline_pad_in_smp
> +#if defined(CONFIG_SMP)
> +#define ____cacheline_pad_in_smp struct { char x; } ____cacheline_maxaligned_in_smp
^^^^^^^
Doesn't this add a redundant cacheline if the padding is
previously perfect? Because of the extra byte you're adding?
IIRC, the char x[0]; trick does the job correctly.
next prev parent reply other threads:[~2005-03-16 4:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-16 4:12 Christoph Lameter
2005-03-16 4:23 ` Andrew Morton
2005-03-16 5:04 ` Christoph Lameter
2005-03-16 5:23 ` Andrew Morton
2005-03-16 5:27 ` Christoph Lameter
2005-03-16 4:24 ` Nick Piggin [this message]
2005-03-16 5:05 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110947099.24808.3.camel@npiggin-nld.site \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=christoph@lameter.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®