From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B5047CDB474
	for <linux-kernel@archiver.kernel.org>; Mon, 16 Oct 2023 16:28:43 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233916AbjJPQ2m (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 16 Oct 2023 12:28:42 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60934 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233829AbjJPQ22 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 16 Oct 2023 12:28:28 -0400
Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4789111B;
        Mon, 16 Oct 2023 09:28:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:
        Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
        Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;
        bh=Qn8pjkyvMjlHnGF7bvQJKDrfyyM9Efa1/JCaDoN/WGs=; b=0H5vCEwnQj/P2x0kDiHQc87Ppv
        2+L/CGodNbhCTiYpl7byMQr4Ilz5dRxiH2pCw++3q3SYJbhBRL56w5XM+0gwndVoepmS7acekr4U9
        KG6gEON5so1BqUJQWPG8jGHRsxDwRgOORhVa+8yKQC6w90fOh2QNRWd69IdCSFsnodxc=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1qsQRz-002Mgn-VL; Mon, 16 Oct 2023 18:28:15 +0200
Date:   Mon, 16 Oct 2023 18:28:15 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     MD Danish Anwar <danishanwar@ti.com>
Cc:     Jacob Keller <jacob.e.keller@intel.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org, srk@ti.com,
        Vignesh Raghavendra <vigneshr@ti.com>, r-gunasekaran@ti.com,
        Roger Quadros <rogerq@kernel.org>
Subject: Re: [PATCH net v2] net: ti: icssg-prueth: Fix r30 CMDs bitmasks
Message-ID: <11109e7d-139b-4c8c-beaa-e1e89e355b1b@lunn.ch>
References: <20231016161525.1695795-1-danishanwar@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231016161525.1695795-1-danishanwar@ti.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 16, 2023 at 09:45:25PM +0530, MD Danish Anwar wrote:
> The bitmask for EMAC_PORT_DISABLE and EMAC_PORT_FORWARD has been changed
> in the ICSSG firmware REL.PRU-ICSS-ETHERNET-SWITCH_02.02.12.05.
> 
> The current bitmasks are wrong and as a result EMAC_PORT_DISABLE and
> EMAC_PORT_FORWARD commands doesn not work.
> Update r30 commands to use the same bitmask as used by the ICSSG firmware
> REL.PRU-ICSS-ETHERNET-SWITCH_02.02.12.05.
> 
> These bitmasks are not backwards compatible. This will work with
> firmware version REL.PRU-ICSS-ETHERNET-SWITCH_02.02.12.05 and above but
> not with lower firmware versions.

Breaking backwards compatibility is generally not allowed.

As far as i understand the driver, it loads whatever version of
firmware is available. It does not ask for a specific version. So you
should ask the firmware what version it is, and then handle the
bitmask as appropriate.

How many different versions of REL.PRU-ICSS-ETHERNET-SWITCH have been
released? They don't appear to be part of linux-firmware.git :-(

    Andrew

---
pw-bot: cr