mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
To: linux-kernel@vger.kernel.org
Subject: [PATCH][3/5] New member for proc_inode: ctl_name
Date: Sun, 20 Mar 2005 11:14:43 +0100	[thread overview]
Message-ID: <1111313683.3a45D.17773@neapel230.server4you.de> (raw)
In-Reply-To: <1111278162.22BA.5209@neapel230.server4you.de>

Add new field to struct proc_inode and struct pid_entry: ctl_name.  It
will be used to hold the ctl_name value of the sysctl that is responsible
for the respective inode or pid_entry.  Also initialize this value for
our example sysctl (proc.cmdline).

diff -pur l1/fs/proc/base.c l2/fs/proc/base.c
--- l1/fs/proc/base.c	2005-03-19 19:59:00.000000000 +0100
+++ l2/fs/proc/base.c	2005-03-19 19:59:43.000000000 +0100
@@ -35,6 +35,7 @@
 #include <linux/seccomp.h>
 #include <linux/cpuset.h>
 #include <linux/audit.h>
+#include <linux/sysctl.h>
 #include "internal.h"
 
 /*
@@ -130,9 +131,18 @@ struct pid_entry {
 	int len;
 	char *name;
 	mode_t mode;
+#ifdef CONFIG_SYSCTL
+	int ctl_name;
+#endif
 };
 
-#define E(type,name,mode) {(type),sizeof(name)-1,(name),(mode)}
+#ifdef CONFIG_SYSCTL
+#define E(type, name, mode)		{(type), sizeof(name)-1, (name), (mode), 0}
+#define S(type, name, mode, ctl_name)	{(type), sizeof(name)-1, (name), (mode), (ctl_name)}
+#else
+#define E(type, name, mode)		{(type), sizeof(name)-1, (name), (mode)}
+#define S(type, name, mode, ctl_name)	{(type), sizeof(name)-1, (name), (mode)}
+#endif	/* CONFIG_SYSCTL */
 
 static struct pid_entry tgid_base_stuff[] = {
 	E(PROC_TGID_TASK,      "task",    S_IFDIR|S_IRUGO|S_IXUGO),
@@ -140,7 +150,7 @@ static struct pid_entry tgid_base_stuff[
 	E(PROC_TGID_ENVIRON,   "environ", S_IFREG|S_IRUSR),
 	E(PROC_TGID_AUXV,      "auxv",	  S_IFREG|S_IRUSR),
 	E(PROC_TGID_STATUS,    "status",  S_IFREG|S_IRUGO),
-	E(PROC_TGID_CMDLINE,   "cmdline", S_IFREG|S_IRUGO),
+	S(PROC_TGID_CMDLINE,   "cmdline", S_IFREG|S_IRUGO, PROC_CMDLINE),
 	E(PROC_TGID_STAT,      "stat",    S_IFREG|S_IRUGO),
 	E(PROC_TGID_STATM,     "statm",   S_IFREG|S_IRUGO),
 	E(PROC_TGID_MAPS,      "maps",    S_IFREG|S_IRUGO),
@@ -176,7 +186,7 @@ static struct pid_entry tid_base_stuff[]
 	E(PROC_TID_ENVIRON,    "environ", S_IFREG|S_IRUSR),
 	E(PROC_TID_AUXV,       "auxv",	  S_IFREG|S_IRUSR),
 	E(PROC_TID_STATUS,     "status",  S_IFREG|S_IRUGO),
-	E(PROC_TID_CMDLINE,    "cmdline", S_IFREG|S_IRUGO),
+	S(PROC_TID_CMDLINE,    "cmdline", S_IFREG|S_IRUGO, PROC_CMDLINE),
 	E(PROC_TID_STAT,       "stat",    S_IFREG|S_IRUGO),
 	E(PROC_TID_STATM,      "statm",   S_IFREG|S_IRUGO),
 	E(PROC_TID_MAPS,       "maps",    S_IFREG|S_IRUGO),
@@ -226,6 +236,7 @@ static struct pid_entry tid_attr_stuff[]
 #endif
 
 #undef E
+#undef S
 
 #ifdef CONFIG_SYSCTL
 /* Order and number of elements must match CTL_PROC table in sysctl.h! */
@@ -1150,6 +1161,9 @@ static struct inode *proc_pid_make_inode
 	get_task_struct(task);
 	ei->task = task;
 	ei->type = ino;
+#ifdef CONFIG_SYSCTL
+	ei->ctl_name = 0;
+#endif
 	inode->i_uid = 0;
 	inode->i_gid = 0;
 	if (ino == PROC_TGID_INO || ino == PROC_TID_INO || task_dumpable(task)) {
@@ -1458,6 +1472,9 @@ static struct dentry *proc_pident_lookup
 		goto out;
 
 	ei = PROC_I(inode);
+#ifdef CONFIG_SYSCTL
+	ei->ctl_name = p->ctl_name;
+#endif
 	inode->i_mode = p->mode;
 	/*
 	 * Yes, it does not scale. And it should not. Don't add
diff -pur l1/fs/proc/internal.h l2/fs/proc/internal.h
--- l1/fs/proc/internal.h	2005-02-12 09:26:31.000000000 +0100
+++ l2/fs/proc/internal.h	2005-03-19 19:55:44.000000000 +0100
@@ -46,3 +46,8 @@ static inline int proc_type(struct inode
 {
 	return PROC_I(inode)->type;
 }
+
+static inline int proc_ctl_name(struct inode *inode)
+{
+	return PROC_I(inode)->ctl_name;
+}
diff -pur l1/include/linux/proc_fs.h l2/include/linux/proc_fs.h
--- l1/include/linux/proc_fs.h	2005-02-12 09:26:36.000000000 +0100
+++ l2/include/linux/proc_fs.h	2005-03-19 19:55:44.000000000 +0100
@@ -238,6 +238,7 @@ extern void kclist_add(struct kcore_list
 struct proc_inode {
 	struct task_struct *task;
 	int type;
+	int ctl_name;
 	union {
 		int (*proc_get_link)(struct inode *, struct dentry **, struct vfsmount **);
 		int (*proc_read)(struct task_struct *task, char *page);


  parent reply	other threads:[~2005-03-20 10:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-20  0:22 [PATCH][0/6] Change proc file permissions with sysctls Rene Scharfe
2005-03-20  4:22 ` Bodo Eggert
2005-03-20  6:08 ` Albert Cahalan
2005-03-20  9:48   ` Jan Engelhardt
2005-03-20 10:14 ` Rene Scharfe [this message]
2005-03-20 10:14 ` [PATCH][4/5] Add inode_operations for proc sysctl Rene Scharfe
2005-03-20 10:14 ` [PATCH][6/5] Bonus: unrelated minor cleanup of enum pid_directory_inos Rene Scharfe
2005-03-20 10:14 ` [PATCH][2/5] Sysctl for proc Rene Scharfe
2005-03-20 10:14 ` [PATCH][5/5] Four more sysctls Rene Scharfe
2005-03-20 10:14 ` [PATCH][1/5] Introduce proc_domode Rene Scharfe
2005-03-20 10:32   ` Jan Engelhardt
2005-03-20 10:40     ` Rene Scharfe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1111313683.3a45D.17773@neapel230.server4you.de \
    --to=rene.scharfe@lsrfire.ath.cx \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®