mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nigel Cunningham <ncunningham@cyclades.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Russell Miller <rmiller@duskglow.com>,
	erik.andren@gmail.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Suspend-to-disk woes
Date: Mon, 21 Mar 2005 11:14:26 +1100	[thread overview]
Message-ID: <1111364066.9720.2.camel@desktop.cunningham.myip.net.au> (raw)
In-Reply-To: <20050319212922.GA1835@elf.ucw.cz>

Hi.

On Sun, 2005-03-20 at 08:29, Pavel Machek wrote:
> On So 19-03-05 12:20:35, Russell Miller wrote:
> > On Saturday 19 March 2005 05:26, Pavel Machek wrote:
> > 
> > > Checking that would be hard, but you might want to provide patch to check
> > > last-mounted dates of filesystems and panic if they changed.
> > > 				Pavel
> > 
> > Then how would you fix it?  There'd also have to be a way to reset it, 
> 
> boot with "noresume", then mkswap.

Yuck! Why panic when you know what is needed? A better solution is to
tell the user they've messed up and given them the option to (1) reboot
and try another kernel or (2) have swsusp restore the original swap
signature and continue booting. This is what suspend2 does (with a
timeout for the prompt). It's not that hard.

Regards,

Nigel
-- 
Nigel Cunningham
Software Engineer, Canberra, Australia
http://www.cyclades.com
Bus: +61 (2) 6291 9554; Hme: +61 (2) 6292 8028;  Mob: +61 (417) 100 574

Maintainer of Suspend2 Kernel Patches http://suspend2.net


  parent reply	other threads:[~2005-03-21  0:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-18 16:28 Erik Andrén
2005-03-18 17:54 ` Stefan Seyfried
2005-03-18 22:04 ` Nigel Cunningham
2005-03-19 13:26 ` Pavel Machek
2005-03-19 20:20   ` Russell Miller
2005-03-19 21:29     ` Pavel Machek
2005-03-19 21:44       ` Russell Miller
2005-03-21  0:14       ` Nigel Cunningham [this message]
2005-03-21  0:17         ` Matthew Garrett
2005-03-21  5:59           ` Nigel Cunningham
2005-03-21  9:33             ` Stefan Seyfried
2005-03-21 21:38               ` Nigel Cunningham
2005-03-21  7:38         ` Stefan Seyfried
2005-03-21 11:23           ` Nigel Cunningham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1111364066.9720.2.camel@desktop.cunningham.myip.net.au \
    --to=ncunningham@cyclades.com \
    --cc=erik.andren@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rmiller@duskglow.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®