From: jamal <hadi@cyberus.ca>
To: Thomas Graf <tgraf@suug.ch>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Yichen Xie <yxie@cs.stanford.edu>,
linux-kernel@vger.kernel.org, netdev@oss.sgi.com,
"David S. Miller" <davem@davemloft.net>,
kaber@trash.net
Subject: Re: memory leak in net/sched/ipt.c?
Date: 23 Mar 2005 08:32:40 -0500 [thread overview]
Message-ID: <1111584760.1089.112.camel@jzny.localdomain> (raw)
In-Reply-To: <20050323132332.GQ3086@postel.suug.ch>
On Wed, 2005-03-23 at 08:23, Thomas Graf wrote:
>
> kfree simply does nothing if it is given a null pointer so that
> goto rtattr_failure for t == NULL is handled just fine without
> a check. I will never get used to this behaviour and policy as
> well though, it somewhat makes code less readable.
>
I cant get used to it either; actually i dont think i would be able
to stop my fingers ;->
> > didnt understand the janitor part.
>
> It will probably be removed again by one of the regular 'remove
> unnecessary pre kfree checks' patchsets.
>
Yes, already Jan Engelhardt <jengelh@linux01.gwdg.de> has made that
point - although he did not post to netdev!! ;->
So ignore my comment Herbert
cheers,
jamal
next prev parent reply other threads:[~2005-03-23 13:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-23 8:13 Yichen Xie
2005-03-23 8:48 ` Jan Engelhardt
2005-03-23 11:30 ` Herbert Xu
2005-03-23 12:40 ` jamal
2005-03-23 12:55 ` Thomas Graf
2005-03-23 13:11 ` jamal
2005-03-23 13:23 ` Thomas Graf
2005-03-23 13:32 ` jamal [this message]
2005-03-23 13:40 ` Jan Engelhardt
2005-03-23 14:05 ` jamal
2005-03-23 14:12 ` jamal
2005-03-23 13:03 ` Jan Engelhardt
2005-03-23 18:27 ` Yichen Xie
2005-03-23 19:01 ` Jan Engelhardt
2005-03-23 19:07 ` Randy.Dunlap
2005-03-23 20:37 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1111584760.1089.112.camel@jzny.localdomain \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=tgraf@suug.ch \
--cc=yxie@cs.stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®